EM-644 and EM-1237 #125
Merged
EM-644 and EM-1237 #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to adjust for the padding that the rest of the content lives within this fixes the buy box being 20px outside of the area that the rest of the content is in see https://trello.com/c/OzxNjQma/34-buy-box-is-out-of-alignment-with-content-area and https://cb-content-enablement.atlassian.net/browse/EM-1480
b/c flag needs to not quite be on the edge
…anels--full-bleed-image update text-image-panels--full-bleed-image mixin so that text stays within .container
after setting max width for headline text it was no longer centered, this fixes that
mobile safari was scaling up font size on one paragraph on new why cb page in about section this paragraph wasn't styled any differently from other paragraphs on the page. it was using .employer-scope styles Safari has a bug where media queries and rems don't work together: https://stackoverflow.com/questions/13237782/safari-doesnt-calculate-rem-units-correct-when-scaling-with-media-width-heigh and https://stackoverflow.com/questions/25960783/why-does-safari-calculate-rems-in-media-queries-differently-than-other-browsers Added this property to fix it: http://www.456bereastreet.com/archive/201011/beware_of_-webkit-text-size-adjustnone/ and https://developer.mozilla.org/en-US/docs/Web/CSS/text-size-adjust But only for Safari, I didn't see the issue on ios Chrome or Firefox
EM-1237: Why CareerBuilder Layout and Placeholders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accidentally merged #123 into this merged/deleted branch instead of
masterMerging this to
master