feat: option to use ByteArray instead of Array<felt252> #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/parser/mod.rs
Outdated
| @@ -28,6 +28,7 @@ pub struct SvgElement { | |||
| pub attributes: HashMap<String, String>, | |||
| pub replacement: HashMap<String, String>, | |||
| pub nodes: Vec<SvgElement>, | |||
| pub type_override: Option<String>, | |||
There was a problem hiding this comment.
I think we should use an enum for that kind of handling. Enum can implement Display trait, it should simplify handling of logic afterwards
There was a problem hiding this comment.
I'm still quite new to Rust, thanks a lot for your advice!
TropicalDog17
force-pushed
the
feat/string-type
branch
from
c2cf65b to
af261e3
Compare
MartianGreed
approved these changes
Jul 1, 2024
test-2.cairo
Outdated
There was a problem hiding this comment.
this file should be ignored !
test.cairo
Outdated
There was a problem hiding this comment.
this file can be ignored too or placed into an examples/cairo directory
TropicalDog17
force-pushed
the
feat/string-type
branch
from
af261e3 to
c01f434
Compare
MartianGreed
suggested changes
Jul 1, 2024
examples/test-2.cairo
Outdated
Comment on lines
9
to
10
| svg.append('<g><text><tspan>Carbon units</t' | ||
| svg.append('span></text></g>' |
There was a problem hiding this comment.
can we fix this file please ?
MartianGreed
approved these changes
Jul 4, 2024
This was referenced Nov 21, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #9
Checklist