Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cairo Contract] - Impl LockerHandler Interface Functions #5

Closed
3 tasks
julienbrs opened this issue Nov 19, 2024 · 5 comments · Fixed by #15
Closed
3 tasks

[Cairo Contract] - Impl LockerHandler Interface Functions #5

julienbrs opened this issue Nov 19, 2024 · 5 comments · Fixed by #15
Assignees
Labels

Comments

@julienbrs
Copy link
Contributor

julienbrs commented Nov 19, 2024

Description

Implement the missing functions in the LockerHandler interface to ensure users can interact fully with the locker system.

Acceptance Criteria

  • Implement lock_credits, is_lock_expired, is_lock_offsettable, offset_credits, get_lock, get_user_locks, get_locked_credits, get_total_locks.
  • Add complete and complex test coverage
  • Emit events when needed

Additional context

[ Hard Difficulty - Cairo ]

@ibrahimtaib
Copy link
Contributor

hi, can I please be assigned to this issue? I would implement the functions accordingly to what the offsetter from the main protocol is doing.
thanks a lot

@SoarinSkySagar
Copy link
Contributor

May I work on this issue @julienbrs?

I will write the functions as expected and add extensive tests for the same.

eta: 3 days

@TropicalDog17
Copy link

@julienbrs
Copy link
Contributor Author

julienbrs commented Nov 21, 2024

Hi, I'm assigning it to @ibrahimtaib as they were the first one to ask. Please join TG to discuss about it if needed: https://t.me/carbonableOD
Issue might be reassigned during ODHack if the contributor drops the isue.
@ibrahimtaib please ask on onlydust website also

@ibrahimtaib
Copy link
Contributor

asking through OD, thanks for the assignation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants