Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to use ByteArray instead of Array<felt252> #9

Closed
5 tasks
MartianGreed opened this issue Jun 18, 2024 · 4 comments · Fixed by #10
Closed
5 tasks

Option to use ByteArray instead of Array<felt252> #9

MartianGreed opened this issue Jun 18, 2024 · 4 comments · Fixed by #10
Assignees
Labels
good first issue Good for newcomers ODHack

Comments

@MartianGreed
Copy link
Contributor

MartianGreed commented Jun 18, 2024

Description

When we created this tool a while only available option to return strings was to return Array<felt252>.

Additional Information

[ High Difficulty - Rust - Low Priority]

TODO

Implement an option that will be used like this :

cargo run -- generate path/to/yourfile.svg --type ByteArray

Option will default to Array<felt252>.

With --type option specified, program will then return generated cairo with type passed in option.

Acceptance Criteria

  • Add an option to change cairo base type (used in functions input and output)
  • Program is usable without the option specified (defaulting to Array<felt252>)
  • Program is usable with option specified and will fail if type other than ByteArray is specified
  • Code decoupling to write cairo program should be decoupled for different type handlers
  • Common code should be then generic
@Khyati729 Khyati729 added good first issue Good for newcomers ODHack labels Jun 19, 2024
@Khyati729
Copy link

Contribute to Carbonable during ODHack:
Provable environmental infra

  • Go to the CarbonableOD Telegram: https://t.me/carbonableOD
  • Present yourself and tell us which issue you want to pick
  • Explain shortly how you want to tackle the issue
  • Ask a question if you need some clarity
  • When you're selected you will be assigned to the issue

@IjayAbby
Copy link

Hello @MartianGreed and @Khyati729, I am a Basecamp 9 starknet graduate and I have recently acquired skills in Cairo and Rust language and would love to take up the issue to make use of my skills. Thank you

@Khyati729
Copy link

Hello @MartianGreed and @Khyati729, I am a Basecamp 9 starknet graduate and I have recently acquired skills in Cairo and Rust language and would love to take up the issue to make use of my skills. Thank you

Hey @IjayAbby
could you please go to telegram : https://t.me/carbonableOD
Present yourself and
explain shortly how you want to tackle the issue

@TropicalDog17
Copy link
Contributor

Hi @Khyati729, could I work on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers ODHack
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants