Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utils): make getEntryIds independent of error type #31

Merged
merged 4 commits into from
Nov 4, 2022
Merged

Conversation

marstamm
Copy link
Member

@marstamm marstamm commented Oct 20, 2022

Currently, the Lint error takes precendent over the local error. Follow-up to fix it: bpmn-io/properties-panel#190

Makes sure that FEEL lint errors map to the correct Properties panel entry

Recording 2022-11-04 at 10 46 52


Related to #22

@marstamm marstamm marked this pull request as ready for review November 4, 2022 09:45
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Nov 4, 2022
@marstamm marstamm requested review from philippfromme, a team and smbea and removed request for a team November 4, 2022 09:45
Copy link
Collaborator

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, focusing the FEEL editor and scrolling it into view doesn't work properly. I'll create a separate issue for that. 🦾

@merge-me merge-me bot merged commit e2d0a3b into main Nov 4, 2022
@merge-me merge-me bot deleted the feel branch November 4, 2022 13:04
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 4, 2022
@marstamm
Copy link
Member Author

marstamm commented Nov 4, 2022

Most likely an issue in the properties panel as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants