-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FEEL errors to linting #22
Comments
@marstamm please open an integration issue in the Web Modeler repository. As discussed, maybe just a version bump is enough. |
Performance
When tested with a 2.000 expression diagram, the lag was noticable but still usable. I think the performance impact is still small enough that we can open the base PRs without performance improvements. Still, I would like to look into into caching now, so we have a solid foundation when we want to introduce Variable null checks and other more resource intensive linting rules |
Caching Spike results Caching creates the challenge of creating hashes for the Objects, so we can figure out if they changed in the next run. We need to do this not only for the Element itself but for the complete subtree, as some lint rules access extension elements while others are using the child elements directly. While I was able to build working caching, the performance is worse than running linting normally and adds time for every element. Instead of caching, we could think about linting changes only, e.g. by integrating into eventBus events. This would require a bigger refactoring, so I will not pursue it further now. |
done via #31 |
Epic: https://github.com/camunda/product-hub/issues/280
Follow-ups:
bpmn-io/properties-panel#190
The text was updated successfully, but these errors were encountered: