feat(rules): add feel linting rule #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marstamm
commented
Oct 20, 2022
Comment on lines
+14
to
+16
| if (!parentNode) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Should never happen, but it does: bpmn-io/bpmn-js#1754
Better be safe than blow up 😄
philippfromme
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds FEEL linting rules to the C8 linting rules.
To test it out, checkout
camunda/linting#feeland link locally.bpmn-io/srgets stuck on cloninglintingfor me. Here is the command anyway, in case it works for you:Upstream PR: camunda/linting#31
related to camunda/linting#22