-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle complex types in NDK metadata #1715
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t currently be represented by the C API
Implement a new OPAQUE metadata type
…eanup old OPAQUE values when they are no longer reachable
…bs in the binary event during a crash
Encode opaque metadata
…-in-report Store opaque metadata values in binary events
Encode opaque metadata into JSON events to be delivered
Android notifier sizes
Generated by 🚫 Danger |
tomlongridge
approved these changes
Jun 28, 2022
This was referenced Jun 29, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Report all metadata added in the Java/Kotlin API in NDK events, rather than only types that can be directly manipulated from the C API.
Increase the maximum size of metadata section names and keys in NDK events to 64 bytes (including a null-terminator) instead of 32.
Design
Metadata that cannot be directly represented by the existing C model is now masked as an
BSG_METADATA_OPAQUE_VALUE
metadata value. These values are pre-encoded as JSON by the NDK plugin before being delivered as a string to the C layer.The direct effect is:
Testing
New unit tests and modified end-to-end tests ensure that no metadata is lost in a native event. The CXX signal test was modified to test the "clear" APIs within the C
on_error
handler, which requires async safety.