Encode opaque metadata #1708
Merged
Encode opaque metadata #1708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android notifier sizes
Generated by 🚫 Danger |
kstenerud
approved these changes
Jun 22, 2022
| internal class OpaqueValue(val json: String) { | ||
| companion object { | ||
| private const val MAX_NDK_STRING_LENGTH = 64 | ||
| private const val US_ASCII_MAX_CODEPOINT = 128 |
There was a problem hiding this comment.
ASCII max codepoint is actually 127, but you also wouldn't want codepoint 127 in a string because it's the DEL control code.
There was a problem hiding this comment.
👍 the check for this was actually < 128 but I'll change it to <= 127 for clarity. This value is only used as a short-path to see if every char will fit into a single UTF-8 byte, no encoding is actually done unless the check fails.
…eanup old OPAQUE values when they are no longer reachable
lemnik
force-pushed
the
PLAT-8582/encode-opaque-metadata
branch
from
63ea0b1 to
a41a5f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Detect metadata values that cannot be represented directly in the C layer and encode them as
OPAQUE. This includes breadcrumbs which use aOpaqueValuemarker object in theMapdelivered to the C layer for storage.Testing
Introduced a new end-to-end test that add complex metadata via the Java layer. This does not fully function yet as the data cannot be retrieved in the error reports (upcoming functionality). The test does however ensure that the new functionality introduces no other failures when adding the metadata.