Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a new OPAQUE metadata type #1707

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

lemnik
Copy link
Contributor

@lemnik lemnik commented Jun 20, 2022

Goal

Introduce a new OPAQUE metadata value type to allow complex metadata values to be stored by the NDK layer for later delivery. This PR introduces the type enum, fields to store the values within, and migrations for existing event files. It does not include any of the encoding or decoding logic.

Changeset

  • Add BSG_METADATA_OPAQUE_VALUE as a possible metadata value type
  • Add opaque_value and opaque_value_size to the bsg_metadata_value struct for storage
  • Bump the size limit of metadata value section and name to 64 chars
  • Migrate all existing report formats to a new version (9) with the new structure

Testing

New test for the latest binary event format, and updated all existing migration tests to cover the change to metadata and breadcrumbs (which also contain metadata).

@lemnik lemnik requested a review from kstenerud June 20, 2022 15:03
@lemnik lemnik marked this pull request as ready for review June 20, 2022 15:03
@bugsnagbot
Copy link
Collaborator

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1862.77 1610.5
arm64_v8a 655.76 405.9
armeabi_v7a 590.23 340.37
x86 729.47 479.61
x86_64 696.71 446.85

Generated by 🚫 Danger

@lemnik lemnik merged commit 8c31bc6 into integration/opaque-metadata Jun 21, 2022
@lemnik lemnik deleted the PLAT-8579/opaque-metadata-type branch June 21, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants