Implement a new OPAQUE metadata type #1707
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Introduce a new
OPAQUE
metadata value type to allow complex metadata values to be stored by the NDK layer for later delivery. This PR introduces the type enum, fields to store the values within, and migrations for existing event files. It does not include any of the encoding or decoding logic.Changeset
BSG_METADATA_OPAQUE_VALUE
as a possible metadata value typeopaque_value
andopaque_value_size
to thebsg_metadata_value
struct for storagesection
andname
to 64 charsTesting
New test for the latest binary event format, and updated all existing migration tests to cover the change to metadata and breadcrumbs (which also contain metadata).