Settings is now capitalized in panel tour #8198
Conversation
jasonrsadler
changed the title
| @@ -15,8 +15,7 @@ import { Toggle } from '../../../../components/toggle' | |||
| import * as s from './style' | |||
|
|
|||
| export const DynamicListContext = React.createContext< | |||
| Partial<{ setSize: (index: number, size: number) => void }> | |||
| >({}) | |||
| Partial<{ setSize: (index: number, size: number) => void }>>({}) | |||
There was a problem hiding this comment.
This was causing tslint error on win
| @@ -29,7 +29,7 @@ export const localeStrings = { | |||
| onboardingPanelWelcomeHeader: 'Welcome to Brave Rewards!', | |||
| onboardingPanelWelcomeText: 'Brave Private Ads reward you with tokens to support content creators unlike traditional ads, all while keeping your personal information private.', | |||
| onboardingPanelAdsHeader: 'Where do ads show up?', | |||
| onboardingPanelAdsText: 'Brave Private Ads will appear as a normal notification. You control how often you see these ads in settings.', | |||
| onboardingPanelAdsText: 'Brave Private Ads will appear as a normal notification. You control how often you see these ads in Settings.', | |||
| @@ -617,7 +617,7 @@ | |||
| <message name="IDS_BRAVE_REWARDS_ONBOARDING_PANEL_WELCOME_HEADER" desc="">Welcome to Brave Rewards!</message> | |||
| <message name="IDS_BRAVE_REWARDS_ONBOARDING_PANEL_WELCOME_TEXT" desc="">Brave Private Ads reward you with tokens to support content creators unlike traditional ads, all while keeping your personal information private.</message> | |||
| <message name="IDS_BRAVE_REWARDS_ONBOARDING_PANEL_ADS_HEADER" desc="">Where do ads show up?</message> | |||
| <message name="IDS_BRAVE_REWARDS_ONBOARDING_PANEL_ADS_TEXT" desc="">Brave Private Ads will appear as a normal notification. You control how often you see these ads in settings.</message> | |||
| <message name="IDS_BRAVE_REWARDS_ONBOARDING_PANEL_ADS_TEXT" desc="">Brave Private Ads will appear as a normal notification. You control how often you see these ads in Settings.</message> | |||
There was a problem hiding this comment.
I don't think the string is pulled from grds but adding here if done in future.
| @@ -1508,7 +1508,7 @@ until they verify, or until 90 days have passed. | |||
| Where do ads show up? | |||
| </message> | |||
| <message name="IDS_WHERE_DO_ADS_SHOW_UP_TEXT" desc="Brave rewards onboarding title"> | |||
| Brave Private Ads will appear as a normal notification. You control how often you see these ads in settings. | |||
| Brave Private Ads will appear as a normal notification. You control how often you see these ads in Settings. | |||
There was a problem hiding this comment.
Android modification would need to be tested outside of PR. cc @SergeyZhukovsky
|
Sorry for the delay @jasonrsadler @bsclifton - the changes look good to me, but given I haven't landed my own string fix correctly (yet - #8164), I'd feel better if someone else takes a closer look/r?s. |
|
Adding @karenkliu - want to make sure capitalization for Settings is correct (there have been several casing issues lately) 😄 |
There was a problem hiding this comment.
This looks fine... Not sure we have a hard rule about capitalizing settings. The one we need to watch for is making sure "Brave Private Ads" is always titlecased since it is a proper noun and needs the distinction.
Aside from that, our buttons on desktop should all be Sentence case.
|
Closing as stale |
Resolves brave/brave-browser#14122
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan
cc @zenparsing @emerick