Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings is now capitalized in panel tour #8198

Closed
wants to merge 1 commit into from
Closed

Settings is now capitalized in panel tour #8198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion browser/ui/android/strings/android_brave_strings.grd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1508,7 +1508,7 @@ until they verify, or until 90 days have passed.
Where do ads show up?
</message>
<message name="IDS_WHERE_DO_ADS_SHOW_UP_TEXT" desc="Brave rewards onboarding title">
Brave Private Ads will appear as a normal notification. You control how often you see these ads in settings.
Brave Private Ads will appear as a normal notification. You control how often you see these ads in Settings.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Android modification would need to be tested outside of PR. cc @SergeyZhukovsky

</message>
<message name="IDS_WHEN_DO_YOU_RECEIVE_REWARDS" desc="Brave rewards onboarding title">
When do you receive rewards
Expand Down
3 changes: 1 addition & 2 deletions components/brave_new_tab_ui/containers/newTab/settings/braveToday/publisherPrefs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@ import { Toggle } from '../../../../components/toggle'
import * as s from './style'

export const DynamicListContext = React.createContext<
Partial<{ setSize: (index: number, size: number) => void }>
>({})
Partial<{ setSize: (index: number, size: number) => void }>>({})
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was causing tslint error on win


type PublisherPrefsProps = {
setPublisherPref: (publisherId: string, enabled: boolean) => any
Expand Down
2 changes: 1 addition & 1 deletion components/brave_rewards/resources/extension/brave_rewards/_locales/en_US/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,7 +738,7 @@
"description": ""
},
"onboardingPanelAdsText": {
"message": "Brave Private Ads will appear as a normal notification. You control how often you see these ads in settings.",
"message": "Brave Private Ads will appear as a normal notification. You control how often you see these ads in Settings.",
"description": ""
},
"onboardingPanelScheduleHeader": {
Expand Down
2 changes: 1 addition & 1 deletion components/brave_rewards/resources/shared/components/onboarding/stories/locale_strings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export const localeStrings = {
onboardingPanelWelcomeHeader: 'Welcome to Brave Rewards!',
onboardingPanelWelcomeText: 'Brave Private Ads reward you with tokens to support content creators unlike traditional ads, all while keeping your personal information private.',
onboardingPanelAdsHeader: 'Where do ads show up?',
onboardingPanelAdsText: 'Brave Private Ads will appear as a normal notification. You control how often you see these ads in settings.',
onboardingPanelAdsText: 'Brave Private Ads will appear as a normal notification. You control how often you see these ads in Settings.',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For storybook

onboardingPanelScheduleHeader: 'When do you receive rewards',
onboardingPanelScheduleText: 'Your earned tokens from Brave Private Ads throughout the current month will arrive on the 5th of the next month.',
onboardingPanelAcHeader: 'Giving back made effortless',
Expand Down
2 changes: 1 addition & 1 deletion components/resources/brave_components_strings.grd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,7 @@
<message name="IDS_BRAVE_REWARDS_ONBOARDING_PANEL_WELCOME_HEADER" desc="">Welcome to Brave Rewards!</message>
<message name="IDS_BRAVE_REWARDS_ONBOARDING_PANEL_WELCOME_TEXT" desc="">Brave Private Ads reward you with tokens to support content creators unlike traditional ads, all while keeping your personal information private.</message>
<message name="IDS_BRAVE_REWARDS_ONBOARDING_PANEL_ADS_HEADER" desc="">Where do ads show up?</message>
<message name="IDS_BRAVE_REWARDS_ONBOARDING_PANEL_ADS_TEXT" desc="">Brave Private Ads will appear as a normal notification. You control how often you see these ads in settings.</message>
<message name="IDS_BRAVE_REWARDS_ONBOARDING_PANEL_ADS_TEXT" desc="">Brave Private Ads will appear as a normal notification. You control how often you see these ads in Settings.</message>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the string is pulled from grds but adding here if done in future.

<message name="IDS_BRAVE_REWARDS_ONBOARDING_PANEL_SCHEDULE_HEADER" desc="">When do you receive rewards</message>
<message name="IDS_BRAVE_REWARDS_ONBOARDING_PANEL_SCHEDULE_TEXT" desc="">Your earned tokens from Brave Private Ads throughout the current month will arrive on the 5th of the next month.</message>
<message name="IDS_BRAVE_REWARDS_ONBOARDING_PANEL_AC_HEADER" desc="">Giving back made effortless</message>
Expand Down