Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Settings" should be capitalized in Rewards tour, to match Welcome interstitial #14122

Closed
stephendonner opened this issue Feb 11, 2021 · 0 comments
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/rewards needs-text-change This change requires some careful wording. OS/Desktop

Comments

@stephendonner
Copy link

Description

"Settings" menu-item mention should be capitalized in Rewards tour, to match Welcome interstitial's spelling

Steps to Reproduce

  1. new profile, launch Brave
  2. on the brave://welcome tour, click "Let's go ->"
  3. note that "Settings" is capitalized in "Advanced import options can be found in Settings."
  4. click on the BAT icon to invoke the Rewards tour
  5. On the 2nd page, "Where do ads show up?", note the lower-cased spelling of "settings" in "You control how often you see these ads in settings."

Actual result:

Screen Shot 2021-02-11 at 3 34 30 PM

Expected result:

We should be consistent, and since Settings is a top-level menu item, it's a proper noun and should be capitalized here, too.

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.22.19 Chromium: 89.0.4389.40 (Official Build) nightly (x86_64)
Revision 2c2ed83cd507b23e4845edd09a7d1dfc727daf4b-refs/branch-heads/4389@{#602}
OS macOS Version 11.2.1 (Build 20D74)
Brave 1.21.51 Chromium: 88.0.4324.152 (Official Build) beta (x86_64)
Revision 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS macOS Version 11.2.1 (Build 20D74)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes
@bsclifton bsclifton added the needs-text-change This change requires some careful wording. label Mar 10, 2021
@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale Jan 12, 2023
@Miyayes Miyayes added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/rewards needs-text-change This change requires some careful wording. OS/Desktop
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants