Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Korean l10n (1.20.x). #7664

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Fixes Korean l10n (1.20.x). #7664

merged 1 commit into from
Jan 22, 2021

Conversation

mkarolin
Copy link
Collaborator

Fixes Korean l10n.

Fixes brave/brave-browser#12924
Fixes brave/brave-browser#12898
Uplift from #7661

Submitter Checklist:

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin added the CI/skip Do not run CI builds (except noplatform) label Jan 20, 2021
@mkarolin mkarolin requested a review from a team January 20, 2021 03:35
@mkarolin mkarolin self-assigned this Jan 20, 2021
@mkarolin mkarolin changed the title Merge pull request #7661 from brave/maxk-fix-ko-l10n Fixes Korean l10n (1.20.x). Jan 20, 2021
@kjozwiak kjozwiak added this to the 1.20.x - Beta milestone Jan 22, 2021
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.20.x approved after deliberating with @brave/uplift-approvers. @simonhong also verified the PR on Nightly as per Slack 👍

@kjozwiak kjozwiak merged commit de50363 into 1.20.x Jan 22, 2021
@kjozwiak kjozwiak deleted the maxk-fix-ko-l10n-1.20.x branch January 22, 2021 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip Do not run CI builds (except noplatform)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants