Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect korean translation of brave stats in NTP #12924

Closed
simonhong opened this issue Nov 27, 2020 · 6 comments · Fixed by brave/brave-core#7661
Closed

Incorrect korean translation of brave stats in NTP #12924

simonhong opened this issue Nov 27, 2020 · 6 comments · Fixed by brave/brave-core#7661

Comments

@simonhong
Copy link
Member

simonhong commented Nov 27, 2020

saved is translated to 저장됨 but 저장됨 meaning is more close to stored.
Also Bandwidth is translated to 대역폭 but I think 데이터 would be better.
In Android, 데이터 is used. Android NTP uses 데이터 저장됨.
For Bandwidth saved, 데이터 절약됨 would be much better.

Time saved also has same. I think 절약됨 is more better for saved in this context.
Fro Time saved, 시간 절약됨 would be much better for delivering our behavior.

스크린샷 2020-11-27 오후 5 55 40

@simonhong simonhong added l10n OS/Desktop OS/Android Fixes related to Android browser functionality labels Nov 27, 2020
@simonhong simonhong self-assigned this Jan 20, 2021
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jan 20, 2021
@rebron
Copy link
Collaborator

rebron commented Jan 20, 2021

cc: @mkarolin

@mkarolin
Copy link
Contributor

@simonhong would you mind fixing on Transifex:
https://www.transifex.com/brave/brave/translate/#ko/$/156854277?q=text%3A'Time+saved'
https://www.transifex.com/brave/brave/translate/#ko/$/283247917?q=text%3A'Bandwidth+saved'

I fixed a couple but wasn't sure about some other occurrences. I can pull them down afterwards.

@simonhong
Copy link
Member Author

simonhong commented Jan 20, 2021

@mkarolin Yup, I asked to join transifex today because my existing account seems not working now.
Will check after my join request is accepted.

@simonhong
Copy link
Member Author

@mkarolin added some more fixes there.

@srirambv
Copy link
Contributor

Issue not fixed on Android. #13790 logged as a followup.

@srirambv srirambv removed the OS/Android Fixes related to Android browser functionality label Jan 27, 2021
@LaurenWags
Copy link
Member

LaurenWags commented Jan 27, 2021

Verified passed with

Brave | 1.19.87 Chromium: 88.0.4324.96 (공식 빌드) (x86_64)
-- | --
개정 | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS | macOS 버전 10.15.7(빌드 19H15)

Confirmed updated translations on NTP for Bandwidth saved and Time saved

1.19.86 1.19.87
1 19 86 1 19 87

Verification passed on

Brave 1.19.87 Chromium: 88.0.4324.96 (Official Build) (64-bit)
Revision 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS Ubuntu 18.04 LTS

Confirmed updated translations on NTP for Bandwidth saved and Time saved

image


Verification passed on


Brave | 1.19.87 Chromium: 88.0.4324.96 (공식 빌드) (64비트)
-- | --
개정 | 68dba2d8a0b149a1d3afac56fa74648032bcf46b-refs/branch-heads/4324@{#1784}
OS | Windows 10 OS Version 2004 (Build 19041.746)

Confirmed updated translations on NTP for Bandwidth saved and Time saved

1.19.86 1.19.87
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants