Add brave extension history to components/brave_extension/extension/brave_extension #1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3rd party fingerprinting protection
Revert "Merge pull request #16 from brave/test-fixes"
unblock components unit testing
re-enable components testing, fix broken styles in shields panel
Add settings for cookies and referrer blocking
Update to Webpack 4 and update strings for C66
allow brave-extension to run on chrome
If directly copying into framework bundle, mac_framework_bundle template can cause error when framework bundle version is used. When bundle version is newly added or changed to different version, mac_framework_bundle template tries to removes and create all symbolic links in framework bundle to link to new version. If copying resources directly, it is already copied to bundle before symbolic link in Brave Framework folder is created by template. So, trying to removing existing symbolic link failed because it is real folder.
Use bundle_data to add locale resources to brave framework bundle
18 tasks
petemill
previously approved these changes
Feb 21, 2019
cezaraugusto
previously approved these changes
Feb 21, 2019
|
@cezaraugusto should those code changes be in #1755 since this PR is just the existing history from brave-extension? |
|
ya I didn't see https://github.com/brave/brave-core/pull/1755/commits before reviewing this one and seems addressed in there so I reverted |
cezaraugusto
previously approved these changes
Feb 21, 2019
Fix brave extension & rewards popup doesn't display translated strings when brave is run in dist zip. zip pkg also should include extension's locale files.
Combine brave-extension with brave-core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix brave/brave-browser#1506
Fix brave/brave-browser#3399
Fix brave/brave-browser#1555
This is part 1 of 2 PRs on
brave/brave-coreImportant: Nothing in this PR is new, it is just importing the history from brave-extension and mounting it to
components/brave_extension/extension/brave_extensionPart 2 of 2 can be found here:
#1755
brave/brave-browser branch for this is here:
brave/brave-browser#3446
Motivation for this task:
It reduces duplicated code, it makes uplift management easier, it avoids copying in tree.
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) ongit rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
Reviewer Checklist: