Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards extension popup doesn't display translated strings on linux with dist executable #3399

Closed
simonhong opened this issue Feb 18, 2019 · 3 comments · Fixed by brave/brave-core#1754

Comments

@simonhong
Copy link
Member

simonhong commented Feb 18, 2019

On local, executing brave in src/out/Release/dist, rewards popup doesn't show translated string.

Below is the result with korean locale.
screen shot 2019-02-18 at 15 05 46

@simonhong simonhong added this to the 0.63.x - Nightly milestone Feb 18, 2019
@simonhong simonhong self-assigned this Feb 18, 2019
@tildelowengrimm tildelowengrimm changed the title Shields extension popup doesn't display translated strings on linux with dist executable Rewards extension popup doesn't display translated strings on linux with dist executable Feb 19, 2019
@simonhong
Copy link
Member Author

i18n: xxxx is displayed because chrome.i18n.getMessage() returns null.

export const getMessage = (message: string, substitutions?: string[]): string => {
  if (chrome.i18n) {
    let translated = chrome.i18n.getMessage(message, substitutions)

    if (translated) {
      return translated
    } else {
      return `i18n: ${message}`
    }
  }

  return `i18n missing: ${message}`
}

@simonhong simonhong added the closed/duplicate Issue has already been reported label Feb 20, 2019
@simonhong
Copy link
Member Author

Duplicated issue with #1555.

@srirambv
Copy link
Contributor

srirambv commented Apr 4, 2019

Marking QA/No as its duplicated with #1555 which is on verification list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment