Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bundle brave_extension and brave_rewards into Linux source zip file #3104

Closed
srirambv opened this issue Jan 25, 2019 · 5 comments
Closed

Bundle brave_extension and brave_rewards into Linux source zip file #3104

srirambv opened this issue Jan 25, 2019 · 5 comments
Labels
closed/duplicate Issue has already been reported closed/invalid

Comments

@srirambv
Copy link
Contributor

Description

Bundle brave_extension and brave_rewards into Linux source zip file. Not bundling this caused UI issues on Arch based distros. Thanks to @rjocoleman for finding the root cause of the issue #1150 (comment)

Additional Information

https://community.brave.com/t/brave-shield-ui-bug/33570/63
Bundling the locales would fix the following issues
#1150 #2138 #1555

cc: @bbondy @rebron @bsclifton @kjozwiak would be good to get this done on the next beta/dev and then for release so that fixes the UI for Arch based distros
@srirambv srirambv added OS/Linux priority/P3 The next thing for us to work on. It'll ride the trains. setup/installer labels Jan 25, 2019
@srirambv srirambv added this to the 1.x Backlog milestone Jan 25, 2019
@cezaraugusto cezaraugusto mentioned this issue Jan 29, 2019
Closed
@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@flipsa
Copy link

flipsa commented Feb 28, 2019

Just adding to this and #1150: I use Gentoo and I'm affected as well, so it's not just Arch based distros...

@simonhong
Copy link
Member

Duplicated with #3399 and fixed by #3446.

@simonhong
Copy link
Member

@srirambv Should we set milestone also for closed issue with duplication?

@bbondy
Copy link
Member

bbondy commented Mar 1, 2019

@simonhong only if the steps to reproduce are different and we want to verify it. Otherwise just goes in the duplicate / not actionable milestone. I'll put it there.

@bbondy bbondy added this to the Dupe / Invalid / Not actionable milestone Mar 1, 2019
@simonhong
Copy link
Member

@bbondy got it. Thanks! Done for #1150.

@kjozwiak kjozwiak added closed/duplicate Issue has already been reported and removed OS/Linux priority/P3 The next thing for us to work on. It'll ride the trains. setup/installer labels Mar 1, 2019
@bbondy bbondy removed this from the Dupe / Invalid / Not actionable milestone May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/duplicate Issue has already been reported closed/invalid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@bbondy @flipsa @kjozwiak @rebron @simonhong @srirambv