Use dummy API to bypass #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbondy
approved these changes
Jan 3, 2018
bbondy
reviewed
Jan 3, 2018
| @@ -0,0 +1,18 @@ | |||
| // Copyright 2017 The Brave Authors. All rights reserved. | |||
There was a problem hiding this comment.
nit: I think we want MPL headers for the future.
There was a problem hiding this comment.
should we open an issue to convert them?
There was a problem hiding this comment.
I'll do a pass, there are some others in there too like that.
NejcZdovc
pushed a commit
that referenced
this pull request
Dec 10, 2018
also generate as a standalone library
bbondy
pushed a commit
that referenced
this pull request
Feb 18, 2019
Revert "Merge pull request #16 from brave/test-fixes"
fmarier
pushed a commit
that referenced
this pull request
Oct 29, 2019
This makes version work like the branch option used to, and makes branch so it is used explicitly Fix #17
petemill
pushed a commit
that referenced
this pull request
Jul 27, 2020
This makes version work like the branch option used to, and makes branch so it is used explicitly Fix #17
petemill
pushed a commit
that referenced
this pull request
Jul 28, 2020
This makes version work like the branch option used to, and makes branch so it is used explicitly Fix #17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error C3316: 'const ExtensionFunctionRegistry::FactoryEntry [0]': an array of unknown size cannot be used in a range-based for statementAuditors: @bbondy, @bridiver