Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DB general improvements #7145

Closed
NejcZdovc opened this issue Nov 28, 2019 · 1 comment · Fixed by brave/brave-core#5015
Closed

DB general improvements #7145

NejcZdovc opened this issue Nov 28, 2019 · 1 comment · Fixed by brave/brave-core#5015
Assignees
@NejcZdovc
Labels
dev-concern feature/rewards QA/No release-notes/exclude
Milestone
1.8.x - Release

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Nov 28, 2019 •
edited
Loading

This issue is related to all filed in database folder

  1. Check variables table_name_ to and kTableName

  2. const char* table_name_ = "media_publisher_info"; -> const char table_name[] = "media_publisher_info";

  3. make sure that all pointers that come in are checked with DCHECK and if
@NejcZdovc NejcZdovc added feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon. dev-concern labels Nov 28, 2019
This was referenced Nov 28, 2019
Merged
Merged
@NejcZdovc NejcZdovc mentioned this issue Dec 11, 2019
Merged
32 tasks
@NejcZdovc NejcZdovc mentioned this issue Dec 20, 2019
Merged
32 tasks
@NejcZdovc NejcZdovc mentioned this issue Jan 10, 2020
Merged
32 tasks
@masparrow
Copy link

@NejcZdovc blocked until DB migration brave/brave-core#4252 is finished

@NejcZdovc NejcZdovc removed the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Feb 27, 2020
@NejcZdovc NejcZdovc self-assigned this Mar 23, 2020
@NejcZdovc NejcZdovc added this to the 1.8.x - Nightly milestone Mar 23, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue Mar 23, 2020
@NejcZdovc
Implement db improvments
c0f489f 
Resolves brave/brave-browser#7145
@NejcZdovc NejcZdovc mentioned this issue Mar 23, 2020
Merged
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
dev-concern feature/rewards QA/No release-notes/exclude
Projects
None yet
Milestone
1.8.x - Release
Development

Successfully merging a pull request may close this issue.

Implement db improvements brave/brave-core
2 participants
@NejcZdovc @masparrow