Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement db improvements #5015

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Implement db improvements #5015

merged 1 commit into from
Mar 23, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Mar 23, 2020

Resolves brave/brave-browser#7145

I did 3 things:

  • renamed table_name_ to kTableName
  • fix placement of || in response if
  • added missing DCHECK's

Submitter Checklist:

Test Plan:

  • no need

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc added this to the 1.8.x - Nightly milestone Mar 23, 2020
@NejcZdovc NejcZdovc requested a review from a team March 23, 2020 06:43
@NejcZdovc NejcZdovc self-assigned this Mar 23, 2020
@NejcZdovc NejcZdovc merged commit 2a3b449 into master Mar 23, 2020
@NejcZdovc NejcZdovc deleted the db-improvments branch March 23, 2020 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DB general improvements
2 participants