Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

brave / brave-core Public

Notifications You must be signed in to change notification settings
Fork 904
Star 2.6k

Code
Pull requests 231
Actions
Security
Insights

Additional navigation options

Code
Pull requests
Actions
Security
Insights

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moves media publisher info into separate file #4100

Merged

NejcZdovc merged 1 commit into master from db-media-publisher

Nov 28, 2019

Merged

Moves media publisher info into separate file #4100

NejcZdovc merged 1 commit into master from db-media-publisher

Nov 28, 2019

Conversation 13 Commits 1 Checks 0 Files changed

Conversation

Copy link

Contributor

NejcZdovc commented Nov 28, 2019 •

edited

Loading

Resolves brave/brave-browser#7126

Submitter Checklist:

Submitted a ticket for my issue if one did not already exist.
Used Github auto-closing keywords in the commit message.
Added/updated tests for this change (for new code or code which already has tests).
Verified that these changes build without errors on
- Android
- iOS
- Linux
- macOS
- Windows
Verified that these changes pass automated tests (unit, browser, security tests) on
- iOS
- Linux
- macOS
- Windows
Verified that all lint errors/warnings are resolved (npm run lint)
Ran git rebase master (if needed).
Ran git rebase -i to squash commits (if needed).
Tagged reviewers and labelled the pull request as needed.
Request a security/privacy review as needed.
Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone
Public documentation has been updated as necessary. For instance:

Test Plan:

covered with tests

Reviewer Checklist:

New files have MPL-2.0 license header.
Request a security/privacy review as needed.
Adequate test coverage exists to prevent regressions
Verify test plan is specified in PR before merging to source

After-merge Checklist:

The associated issue milestone is set to the smallest version that the
changes has landed on.
All relevant documentation has been updated.

Sorry, something went wrong.

All reactions

NejcZdovc added the feature/rewards label

NejcZdovc added this to the 1.3.x - Nightly milestone

NejcZdovc self-assigned this

NejcZdovc force-pushed the db-media-publisher branch from 223fef7 to 1b03484 Compare

November 28, 2019 09:18

NejcZdovc marked this pull request as ready for review

November 28, 2019 09:54

NejcZdovc requested a review from a team

November 28, 2019 09:54

NejcZdovc force-pushed the db-media-publisher branch from 1b03484 to af0f680 Compare

November 28, 2019 09:54

tmancey reviewed

View reviewed changes

components/brave_rewards/browser/database/database_media_publisher_info.cc Show resolved Hide resolved

tmancey reviewed

View reviewed changes

components/brave_rewards/browser/database/publisher_info_database.h Outdated Show resolved Hide resolved

tmancey reviewed

View reviewed changes

components/brave_rewards/browser/database/publisher_info_database.cc Outdated Show resolved Hide resolved

tmancey reviewed

View reviewed changes

components/brave_rewards/browser/database/publisher_info_database.cc Outdated Show resolved Hide resolved

tmancey reviewed

View reviewed changes

components/brave_rewards/browser/database/database_media_publisher_info.h Outdated Show resolved Hide resolved

tmancey previously requested changes

View reviewed changes

Copy link

Collaborator

tmancey left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See review comments, thanks

Sorry, something went wrong.

All reactions

tmancey self-requested a review

November 28, 2019 10:15


          Moves media publisher info into separate file

bf52e41

Resolves brave/brave-browser#7126

NejcZdovc force-pushed the db-media-publisher branch from af0f680 to bf52e41 Compare

November 28, 2019 11:10

NejcZdovc dismissed tmancey’s stale review

November 28, 2019 11:10

addressed

tmancey approved these changes

View reviewed changes

Copy link

Collaborator

tmancey left a comment

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

Sorry, something went wrong.

All reactions

NejcZdovc merged commit d60c8fc into master

NejcZdovc deleted the db-media-publisher branch

November 28, 2019 13:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

tmancey tmancey approved these changes

Assignees

Labels

feature/rewards

Projects

None yet

Milestone

1.3.x - Release

Development

Successfully merging this pull request may close these issues.

Move media publisher info table into separate file

2 participants

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.