Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Brave News]: Improve peeking card selection #35659

Closed
Tracked by #37729
LorenzoMinto opened this issue Jan 29, 2024 · 2 comments · Fixed by brave/brave-core#25355
Closed
Tracked by #37729

[Brave News]: Improve peeking card selection #35659

LorenzoMinto opened this issue Jan 29, 2024 · 2 comments · Fixed by brave/brave-core#25355
Assignees
Labels
enhancement feature/brave-news formerly brave-today OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include

Comments

@LorenzoMinto
Copy link

LorenzoMinto commented Jan 29, 2024

Spec: https://docs.google.com/document/d/1HH7pohTPp-8uqdccwK4phOrwqK0-NRo-kkBxTDuWUsM/edit#heading=h.tlm8bpd2rbjl

image (3)

Release notes:

Improved peeking card algorithm in Brave News to show more relevant articles

Test Plan:

Hard to actually test that the new algorithm is working as expected, but:

  1. Peeking card should still show up on the NTP when Brave News is enabled
  2. Refreshing the feed should generate a new peeking card
@LaurenWags
Copy link
Member

@brave/qa-team along side the test plan from #35659 (comment), generally confirm that Brave News is still working

@MadhaviSeelam
Copy link

MadhaviSeelam commented Oct 22, 2024

Verification PASSED using

Brave | 1.72.85 Chromium: 130.0.6723.58 (Official Build) beta (64-bit)
-- | --
Revision | 2c872aa4d2694bc73ec58e3b14538a4008a6381e
OS | Windows 11 Version 23H2 (Build 22631.4317)
  1. Installed 1.72.85
  2. launched Brave
  3. News peak button is shown as expected
  4. enabled News via NTP
  5. news feed loaded as expected for default For You
  6. opened a new tab
  7. confirmed peeking card is shown with latest time stamp
  8. waited for an hour and peeking card is refreshed and timestamp updated (eg. The Guardian World News)
  9. clicked previous card and fresh feed is shown
  10. added few publishers
  11. added few channels
  12. confirmed Top sources are shown along with the channels
  13. clicked Following
  14. waited for about two hours
  15. switched to For You
  16. confirmed new data refresh occurred
  17. switched to Top sources and waited for 4 hours and refreshed the feed
  18. confirmed new data refreshed occurred
  19. switched to Publishers
  20. confirmed new data refresh occurred
  21. switched to Channels
  22. confirmed new data refresh occurred
step 3 step 5 step 7 step 8 step 9 step 10 step 12 step 13 step 16 step 17 step 18 step 20 step 22
Image Image Image Image Image Image Image Image Image Image Image Image Image

@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 22, 2024
@MadhaviSeelam MadhaviSeelam added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement feature/brave-news formerly brave-today OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants