-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Space Tool Improvements 1/2 #480
Conversation
b81f941
to
f1e760e
Compare
52c0f32
to
65967cf
Compare
Let us target |
65967cf
to
7bf6bfe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likely needs another follow up: bpmn-io/bpmn-js#1344 (review)
8bc2a44
to
7ffafe1
Compare
bd70f94
to
2bd04f6
Compare
2bd04f6
to
e4a79df
Compare
9b5270e
to
a56e98e
Compare
This PR is actually ready to be reviewed. |
Then we shall review it. Please move to |
a56e98e
to
bb40a6b
Compare
I rebased this on |
I run
Let's investigate whether we are introducing breaking changes in the PR or the tests are too rigid and assure a buggy behaviour. |
BREAKING CHANGES * label behavior is allowed when laying out connection after space tool was used
These 3 tests are failing because 4851c17 is a breaking change. They all expect connection labels not to be moved when the connection is laid out. That is not the expected behavior: The expected behavior is this: If only the source or target of a connection is moved the connection is laid out. If both source and target move, the connection is moved. I marked the commit introducing the breaking change: 4851c17 |
bb40a6b
to
9040fcf
Compare
Which issue does this PR address?
Breaking Changes
Related to camunda/camunda-modeler#1750
Child of camunda/camunda-modeler#1753
Space tool improvements 2/2: bpmn-io/bpmn-js#1344