Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Space Tool Improvements 2/2 #1344

Merged
merged 7 commits into from
Nov 2, 2022
Merged

Space Tool Improvements 2/2 #1344

merged 7 commits into from
Nov 2, 2022

Conversation

philippfromme
Copy link
Contributor

@philippfromme philippfromme commented Aug 14, 2020 •
edited
Loading

brave_6IU2iiSBYb

brave_55pSWVSfCu

Which issue does this PR address?

Closes #1302

Related to camunda/camunda-modeler#1371
Related to camunda/camunda-modeler#1705
Child of camunda/camunda-modeler#1753

Depends on bpmn-io/diagram-js#480

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Aug 14, 2020
@philippfromme philippfromme mentioned this pull request Aug 14, 2020
Closed
9 tasks
@philippfromme philippfromme force-pushed the bpmn-space-tool branch 2 times, most recently from a9f5d19 to 1c6724b Compare August 14, 2020 09:58
@philippfromme philippfromme marked this pull request as ready for review August 14, 2020 11:40
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Aug 14, 2020
@barmac
Copy link
Member

barmac commented Sep 9, 2020

Is it ready for review?

@philippfromme
Copy link
Contributor Author

Yes, it is. It's part of this effort: camunda/camunda-modeler#1753

barmac
barmac previously requested changes Sep 24, 2020
View reviewed changes
Copy link
Member

@barmac barmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding 737e38b, we don't target features at the main branch. Let's maybe move it to a separate PR or just target the whole PR to develop?

For the label fix, I was surprised by this behaviour:
resize
I'd expect the label to not move at all if parent element is not affected.

@nikku nikku added backlog Queued in backlog and removed needs review Review pending labels Nov 13, 2020 — with bpmn-io-tasks
@philippfromme philippfromme force-pushed the bpmn-space-tool branch 2 times, most recently from 310157c to df8ad0b Compare January 6, 2021 14:25
@philippfromme philippfromme changed the base branch from master to develop January 6, 2021 14:28
@philippfromme philippfromme mentioned this pull request Jan 6, 2021
Merged
@philippfromme philippfromme changed the title Add BPMN-specific Space Tool Space Tool Improvements 2/2 Jan 6, 2021
@philippfromme philippfromme force-pushed the bpmn-space-tool branch 3 times, most recently from 6f0c4a0 to 5a1d265 Compare January 6, 2021 16:59
@philippfromme philippfromme requested review from barmac and nikku January 6, 2021 19:47
@pinussilvestrus pinussilvestrus added needs review Review pending and removed backlog Queued in backlog labels Jan 21, 2021
@nikku nikku force-pushed the bpmn-space-tool branch 2 times, most recently from 4f2c559 to 9860955 Compare January 22, 2021 09:59
nikku
nikku requested changes Jan 22, 2021
View reviewed changes
Copy link
Member

@nikku nikku left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally this one looks pretty 🆒.

Found two last bugs ™️ that could be worth looking into:

capture uEMxtg_optimized

The second one is a visual glitch (preview does not match actual layout). I'd be fine ignoring that one for the monent:

capture FfM36Z_optimized

@philippfromme
Copy link
Contributor Author

I fixed the issue with the attachers (bpmn-io/diagram-js@0476037). The issue with the visual is a minor inconvenience so I'd ignore it for now.

@philippfromme philippfromme requested a review from nikku January 23, 2021 21:37
@philippfromme philippfromme force-pushed the bpmn-space-tool branch 2 times, most recently from 25cc65a to 756079b Compare July 1, 2021 15:27
@philippfromme philippfromme force-pushed the bpmn-space-tool branch 3 times, most recently from 48f4c0e to 99f5280 Compare August 19, 2022 07:18
@philippfromme philippfromme requested review from nikku and barmac August 19, 2022 09:14
@nikku nikku changed the title Space Tool Improvements 2/2 WIP: Space Tool Improvements 2/2 Oct 18, 2022
@philippfromme philippfromme changed the title WIP: Space Tool Improvements 2/2 Space Tool Improvements 2/2 Oct 19, 2022
@philippfromme philippfromme added needs review Review pending and removed backlog Queued in backlog labels Oct 19, 2022
@philippfromme
Copy link
Contributor Author

@barmac This is ready to be reviewed.

@philippfromme philippfromme mentioned this pull request Oct 26, 2022
Closed
1 task
@philippfromme philippfromme dismissed stale reviews from nikku and barmac October 26, 2022 10:01

Outdated

@barmac barmac merged commit d676f4e into develop Nov 2, 2022
@barmac barmac deleted the bpmn-space-tool branch November 2, 2022 08:59
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 2, 2022
@philippfromme
Copy link
Contributor Author

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barmac barmac barmac approved these changes

@nikku nikku Awaiting requested review from nikku

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Labels move twice when adding lane
4 participants
@philippfromme @barmac @nikku @pinussilvestrus