feat(space-tool): allow label behavior for laid out connections

bpmn-io · Jan 6, 2021 · 65967cf · 65967cf
1 parent 6738e08
commit 65967cf
Show file tree

Hide file tree

Showing 2 changed files with 47 additions and 5 deletions.
diff --git a/lib/features/modeling/cmd/SpaceToolHandler.js b/lib/features/modeling/cmd/SpaceToolHandler.js
@@ -108,9 +108,7 @@ SpaceToolHandler.prototype.updateConnectionWaypoints = function(
         target = connection.target,
         waypoints = copyWaypoints(connection),
         axis = getAxisFromDirection(direction),
-        layoutHints = {
-          labelBehavior: false
-        };
+        layoutHints = {};
 
     if (includes(affectedShapes, source) && includes(affectedShapes, target)) {
 

diff --git a/test/spec/features/space-tool/SpaceToolSpec.js b/test/spec/features/space-tool/SpaceToolSpec.js
@@ -503,14 +503,14 @@ describe('features/space-tool', function() {
         id: 'label',
         width: 80, height: 40
       });
-  
+
       modeling.createLabel(childShape, { x: 150, y: 250 }, label);
 
       label1 = elementFactory.createLabel({
         id: 'label1',
         width: 80, height: 40
       });
-  
+
       modeling.createLabel(connection, { x: 300, y: 200 }, label1);
     }));
 
@@ -531,6 +531,50 @@ describe('features/space-tool', function() {
       expect(label1.y).to.equal(180);
     }));
 
+
+    it('should disallow label behavior', inject(function(dragging, eventBus, spaceTool) {
+
+      // when
+      spaceTool.activateMakeSpace(canvasEvent({ x: 0, y: 0 }));
+
+      var layoutConnectionSpy = sinon.spy(function(event) {
+        var context = event.context,
+            hints = context.hints;
+
+        expect(hints.labelBehavior).to.be.false;
+      });
+
+      eventBus.on('commandStack.connection.updateWaypoints.execute', layoutConnectionSpy);
+
+      dragging.move(canvasEvent({ x: 500, y: 0 }));
+      dragging.end();
+
+      // then
+      expect(layoutConnectionSpy).to.have.been.called;
+    }));
+
+
+    it('should allow label behavior', inject(function(dragging, eventBus, spaceTool) {
+
+      // when
+      spaceTool.activateMakeSpace(canvasEvent({ x: 300, y: 0 }));
+
+      var layoutConnectionSpy = sinon.spy(function(event) {
+        var context = event.context,
+            hints = context.hints;
+
+        expect(hints.labelBehavior).to.not.be.false;
+      });
+
+      eventBus.on('commandStack.connection.layout.execute', layoutConnectionSpy);
+
+      dragging.move(canvasEvent({ x: 800, y: 0 }));
+      dragging.end();
+
+      // then
+      expect(layoutConnectionSpy).to.have.been.called;
+    }));
+
   });