[rc] Add support for Angular 9, TypeScript ~3.6 #181

Blackbaud-SteveBrush · 2019-11-20T18:30:36Z

Notes:

The Angular CLI is running a compatibility tool behind the scenes (ngcc) that allows Ivy SPAs to consume libraries built with the older "View Engine" compiler. See: https://next.angular.io/guide/ivy#maintaining-library-compatibility. EDIT: Libraries must be compiled with ng-packagr. I'm also going to try and remove deep imports to see if that fixes it.
Angular recommends that library authors continue to use View Engine (instead of Ivy) because View Engine works with SPAs that choose to use Ivy or not. See: https://next.angular.io/guide/ivy#maintaining-library-compatibility. In other words, we should adjust our skyux build-public-library config to disable Ivy.
Running Ivy is preferable for SPA builds; however, we may need to run ngcc after install (Angular CLI does this behind the scenes). See: https://next.angular.io/guide/ivy#ivy-and-libraries. EDIT: Disabling Ivy for now, until we can get the SKY UX packages (listed in peerDependencies) re-released with ng-packagr.

codecov · 2019-11-20T18:56:25Z

Codecov Report

Merging #181 into rc-4.0.0 will not change coverage by %.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           rc-4.0.0      #181   +/-   ##
==========================================
  Coverage    100.00%   100.00%           
==========================================
  Files            57        57           
  Lines          1694      1694           
  Branches        252       252           
==========================================
  Hits           1694      1694

Flag	Coverage Δ
#builder	`100.00% <0.00%> (ø)`	⬆️
#runtime	`100.00% <0.00%> (ø)`	⬆️
#srcapp	`100.00% <0.00%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab08077...ab08077. Read the comment docs.

config/webpack/build-public-library.webpack.config.js

Blackbaud-SteveBrush · 2019-11-20T19:42:49Z

cli/utils/browser.js

@@ -80,14 +80,16 @@ function browser(argv, skyPagesConfig, stats, port) {

      logger.info(`Launching Local URL: ${localUrl}`);
      open(localUrl, {
-        app: argv.browser
+        app: argv.browser,
+        url: true


Upgraded open to the next major version; they require you to specify if the "thing" you're opening is a URL or not.

Blackbaud-SteveBrush · 2019-11-20T19:43:52Z

src/polyfills.ts

-import 'core-js/es6/map';
-import 'core-js/es6/weak-map';
-import 'core-js/es6/set';
+import 'core-js/es/symbol';


Latest version of core-js replaces the es6 and es7 folders with es.

tsconfig.json

Blackbaud-SteveBrush · 2019-11-21T14:51:49Z

src/polyfills.ts


 /* Evergreen browsers require these. */
 // Used for reflect-metadata in JIT. If you use AOT (and only Angular decorators), you can remove.
-import 'core-js/es7/reflect';
+import 'core-js/proposals/reflect-metadata';


See: zloirock/core-js#573 (comment)

Blackbaud-SteveBrush · 2019-11-21T15:25:00Z

.eslintrc.json

@@ -28,6 +28,7 @@
    "prefer-arrow-callback": "off",
    "prefer-const": "off",
    "prefer-destructuring": "off",
+    "prefer-object-spread": "off",


This rule was turned "on" by default in the latest version of ESLint.

Blackbaud-SteveBrush · 2019-11-22T14:12:50Z

config/protractor/protractor-dev.conf.js

@@ -35,7 +35,7 @@ let config = {
      } else {

        const url = 'https://github.com/blackbaud/skyux-sdk-template';
-        const branch = 'master';
+        const branch = 'rc-4.0.0';


Pointing to a specific branch of the template to get e2e tests to run.

See: https://github.com/blackbaud/skyux-sdk-template/tree/rc-4.0.0

Blackbaud-SteveBrush · 2019-11-22T14:14:58Z

lib/sky-pages-module-generator.js

@@ -123,16 +121,6 @@ function getSource(skyAppConfig) {

  runtimeProviders.push(authTokenProvider);

-  if (skyAppConfig.skyux.auth) {
-    nodeModuleImports.push(`import { XHRBackend, RequestOptions } from '@angular/http';`);
-    nodeModuleImports.push(`import { SkyAuthHttp } from '@skyux/http';`);


Sayonara, SkyAuthHttp!

See: https://github.com/blackbaud/skyux-http/blob/rc-4.0.0/CHANGELOG.md#400-rc0-2019-11-21

Blackbaud-SteveBrush · 2019-11-22T14:16:50Z

tslint.json

-    "use-output-property-decorator": true,
-    "use-host-property-decorator": true,
-    "no-attribute-parameter-decorator": true,
+    "no-attribute-decorator": true,


These rules were renamed.

See: mgechev/codelyzer#791 (comment)

package.json

Blackbaud-SteveBrush · 2020-01-30T15:09:50Z

package.json

-    "@skyux/theme": "^3.4.0",
-    "@types/core-js": "^2.5.0",
-    "codelyzer": "^4.5.0",
-    "core-js": "^2.6.3",


I promoted core-js to a hard dependency of Builder, since Angular 9 CLI has taken ownership of core-js and how it's implemented internally.

Blackbaud-SteveBrush · 2020-01-30T15:11:52Z

package.json

-    "codelyzer": "^4.5.0",
-    "core-js": "^2.6.3",
-    "rxjs": "^6.3.3",
-    "rxjs-compat": "^6.3.3",


Removed rxjs-compat as a peer dependency (consumers can still install it if they wish).

Blackbaud-SteveBrush · 2020-01-30T15:12:47Z

runtime/index.ts

@@ -1,3 +1,2 @@
 export * from './bootstrapper';
 export * from './config';
-export * from './runtime.module';


No one should be using the runtime module (we left it in for backwards compatibility with SKY UX 2).

* [rc] Merge master (#180) * [rc] Upgrade karma and jasmine dependencies (#152) * [rc] Use `dart-sass` instead of `node-sass` (#157) ## Breaking changes: - Any usage of `/deep/` will fail to compile; should be replaced with the proprietary `:ng-deep`. * [rc] Added support for `ng-packagr` (#201) * [rc] Added support for Angular 9, TypeScript ~3.6 (#181) * Update package.json/changelog for 4.0.0-rc.0 release (#211) * [rc] Update `@skyux/config`; style sheet injection (#212) * Update changelog/package.json for 4.0.0-rc.1 release (#213) * Update changelog/package.json for 4.0.0-rc.1 release * Doc tweaks Co-authored-by: John Lyons <[email protected]> * Rc 4.0.0 latest master 2020 02 20 (#217) * [rc] Enable Ivy; drop RxJS 5 (#218) * [rc] Update changelog/package.json for 4.0.0-rc.2 release (#219) * Update changelog/package.json for 4.0.0-rc.2 release * Updated changelog * [rc] Upgrade dependencies; merge master (#222) * [rc] Upgrade dependencies * Added babel loader. Targeting only ansi-regex and strip-ansi packages in node_modules (#221) * Added babel loader. Targeting specifically for ansi-regex package in node_modules. * Added test. * Added `strip-ansi` to known packages. * Updated for 3.15.2 (#223) * Updated for 3.15.2 * Incorporated feedback * Wording tweak Co-authored-by: John Lyons <[email protected]> Co-authored-by: Bobby Earl <[email protected]> Co-authored-by: John Lyons <[email protected]> * Updated changelog/package.json for 4.0.0-rc.3 release * [rc] Make `@skyux-sdk/pact` optional (#224) * [rc] Upgraded dependencies; merged master (#236) * Updated changelog/package.json for 4.0.0-rc.4 release * [rc] Upgraded dependencies (#238) * Updated changelog/package.json for 4.0.0-rc.5 release * [rc] Merge master, upgrade dependencies (#244) * Updated changelog/package.json for 4.0.0-rc.6 release * [rc] Use `public_api.ts` for libraries (#248) * [rc] Update changelog/package.json for 4.0.0-rc.7 release (#250) * Fixed test warning * [rc] Upgrade dependencies (#253) * Updated changelog/package.json for 4.0.0-rc.8 release * [rc] Upgraded help-client; dependencies (#254) * [rc] Upgrade dependencies * Upgrade packages * Fix dependencies * Updated changelog/package.json for 4.0.0-rc.9 release * Initialize theme service with theme mapped to current service ID (#255) * [rc] Upgraded dependencies (#257) * Added babel loader. Targeting only ansi-regex and strip-ansi packages in node_modules (#221) * Added babel loader. Targeting specifically for ansi-regex package in node_modules. * Added test. * Added `strip-ansi` to known packages. * Updated for 3.15.2 (#223) * Updated for 3.15.2 * Incorporated feedback * Wording tweak Co-authored-by: John Lyons <[email protected]> * Add viewport margin top for viewkeeper when omnibar enabled (#227) * Updated CHANGELOG and package.json for 3.16.0 release (#228) * Updated CHANGELOG and package.json for 3.16.0 release * Tweaked CHANGELOG entry * Setting pathMatch property on redirects. (#230) * Updated CHANGELOG and package files for 3.16.1. (#231) * Updated CHANGELOG and package files for 3.16.1. * Incorporated feedback. * Updated babel. (#234) * Updated files for 3.16.2. (#235) * Bump minimist from 1.2.0 to 1.2.2 (#232) Bumps [minimist](https://github.com/substack/minimist) from 1.2.0 to 1.2.2. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.0...1.2.2) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update license (#241) Updated license date to address blackbaud/skyux2-docs#894 * Added theming support (#242) Co-authored-by: Steve Brush <[email protected]> * Updated CHANGELOG and package.json for 3.17.0 release (#243) * [rc] Upgrade dependencies; merge master * Fix test * Fix peers * Upgrade auth-client Co-authored-by: Bobby Earl <[email protected]> Co-authored-by: John Lyons <[email protected]> Co-authored-by: Paul Crowder <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Denise Pena <[email protected]> * Updated changelog/package.json for 4.0.0-rc.10 release * [rc] Improve AoT bundle size (#258) * Updated changelog/package.json for 4.0.0-rc.11 release * [rc] Merge master; upgrade dependencies (#263) * [rc] Merge master * Upgrade packages * Upgrade testing lib * Updated changelog/package.json for 4.0.0-rc.12 release * [rc] Upgrade Protractor (#264) * [rc] Merge master (#266) * Updated changelog/package.json for 4.0.0-rc.13 release * Updated changelog/package.json for 4.0.0-rc.14 release * [rc] Upgraded dependencies (#271) * Updated changelog/package.json for 4.0.0-rc.15 release * [rc] Upgraded dependencies (#273) * Added `no-unused-variable` to `tslint.json` (#277) * Updated changelog/package.json for 4.0.0-rc.16 release * Adjustments * Change date * Wording tweak * Fix typo * Wording tweak * Add missing articles * Fix changelog Co-authored-by: Erika McVey <[email protected]> Co-authored-by: John Lyons <[email protected]> Co-authored-by: Bobby Earl <[email protected]> Co-authored-by: Paul Crowder <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Denise Pena <[email protected]>

Blackbaud-SteveBrush added 13 commits September 3, 2019 09:17

Implement Dart SASS

98489b0

Upgraded webpack

ce0daa5

Merged master

a00d18a

Merge master

2cc3078

Angular 9

eac54ba

Merge branch 'rc-4.0.0' into dart-sass

4841822

Add appveyor

6eb8a56

Merge branch 'rc-4.0.0' into rc-angular-9

5b79532

Merge branch 'rc-4.0.0' into dart-sass

bc344ed

Fix package lock

027eb88

Merge branch 'dart-sass' into rc-angular-9

282ff06

Upgrade core-js, webpack and loaders

931c6d9

Use Common HTTP

b9a0c6c

Blackbaud-SteveBrush added 9 commits November 20, 2019 19:49

Use css-loader, to-string-loader

bdd7031

Use dev branch for template

ad63019

Updated packages

89a05f5

Update packages

9fddd12

Fix coverage

21bc965

Disable ivy for now

02c95fb

Update packages

2a57428

Add ngDevMode

85916bf

Update modals

ed0dca0

Blackbaud-SteveBrush commented Nov 22, 2019

View reviewed changes

Revert webpack raw-loader changes

ae0f3ab

Blackbaud-SteveBrush mentioned this pull request Jan 22, 2020

Upgrade core-js to >= 3 #198

Closed

Blackbaud-SteveBrush added 4 commits January 22, 2020 12:25

Merge branch 'rc-4.0.0' into rc-angular-9

42aaf39

Updated minor versions

5aefd25

Update packages

b17b7a6

Update packages

4aaccbc

Blackbaud-SteveBrush added 6 commits January 27, 2020 11:30

Revert Ivy config

0022f49

Disable Ivy

d898502

Make core-js a dependency

ed1c7cc

Remove runtime module

2e9f931

Re-add pact stuff

7bd6d2e

Add inline comments

6c17d87

Blackbaud-SteveBrush commented Jan 30, 2020

View reviewed changes

Blackbaud-SteveBrush added 10 commits January 30, 2020 10:13

Comment cleanup

19396e6

Update package

e8c2bd3

Enable Ivy

0651d66

Upgrade packages

7301eb5

Update packages

d898c6f

Merge branch 'rc-4.0.0' into rc-angular-9

8d7fc3f

Merge branch 'rc-4.0.0' into rc-angular-9

bf6f7f7

Update i18n

a3f928b

Merge branch 'rc-4.0.0' into rc-angular-9

a292990

Update packages

ab08077

Blackbaud-SteveBrush marked this pull request as ready for review February 12, 2020 20:33

Blackbaud-SteveBrush requested a review from Blackbaud-PaulCrowder February 12, 2020 20:59

Blackbaud-PaulCrowder approved these changes Feb 12, 2020

View reviewed changes

Blackbaud-SteveBrush merged commit b4baae4 into rc-4.0.0 Feb 12, 2020

Blackbaud-SteveBrush deleted the rc-angular-9 branch February 12, 2020 21:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[rc] Add support for Angular 9, TypeScript ~3.6 #181

[rc] Add support for Angular 9, TypeScript ~3.6 #181

Blackbaud-SteveBrush commented Nov 20, 2019 •

edited

Loading

codecov bot commented Nov 20, 2019 •

edited

Loading

Blackbaud-SteveBrush Nov 20, 2019

Blackbaud-SteveBrush Nov 20, 2019

Blackbaud-SteveBrush Nov 21, 2019

Blackbaud-SteveBrush Nov 21, 2019

Blackbaud-SteveBrush Nov 22, 2019

Blackbaud-SteveBrush Nov 22, 2019

Blackbaud-SteveBrush Nov 22, 2019

Blackbaud-SteveBrush Jan 30, 2020

Blackbaud-SteveBrush Jan 30, 2020

Blackbaud-SteveBrush Jan 30, 2020

[rc] Add support for Angular 9, TypeScript ~3.6 #181

[rc] Add support for Angular 9, TypeScript ~3.6 #181

Conversation

Blackbaud-SteveBrush commented Nov 20, 2019 • edited Loading

codecov bot commented Nov 20, 2019 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Blackbaud-SteveBrush commented Nov 20, 2019 •

edited

Loading

codecov bot commented Nov 20, 2019 •

edited

Loading