-
Notifications
You must be signed in to change notification settings - Fork 15
[rc] Add support for Angular 9, TypeScript ~3.6 #181
Changes from 15 commits
98489b0
ce0daa5
a00d18a
2cc3078
eac54ba
4841822
6eb8a56
5b79532
bc344ed
027eb88
282ff06
931c6d9
b9a0c6c
bdd7031
ad63019
89a05f5
9fddd12
21bc965
02c95fb
2a57428
85916bf
ed0dca0
ae0f3ab
42aaf39
5aefd25
b17b7a6
4aaccbc
0022f49
d898502
ed1c7cc
2e9f931
7bd6d2e
6c17d87
19396e6
e8c2bd3
0651d66
7301eb5
d898c6f
8d7fc3f
bf6f7f7
a3f928b
a292990
ab08077
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -80,14 +80,16 @@ function browser(argv, skyPagesConfig, stats, port) { | |
|
||
logger.info(`Launching Local URL: ${localUrl}`); | ||
open(localUrl, { | ||
app: argv.browser | ||
app: argv.browser, | ||
url: true | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Upgraded |
||
}); | ||
break; | ||
|
||
case 'host': | ||
logger.info(`Launching Host URL: ${hostUrl}`); | ||
open(hostUrl, { | ||
app: argv.browser | ||
app: argv.browser, | ||
url: true | ||
}); | ||
break; | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -35,7 +35,7 @@ let config = { | |
} else { | ||
|
||
const url = 'https://github.com/blackbaud/skyux-sdk-template'; | ||
const branch = 'master'; | ||
const branch = 'rc-4.0.0'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Pointing to a specific branch of the template to get e2e tests to run. See: https://github.com/blackbaud/skyux-sdk-template/tree/rc-4.0.0 |
||
|
||
console.log('Running command using full install.'); | ||
common.rimrafPromise(common.tmp) | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -77,7 +77,6 @@ function getSource(skyAppConfig) { | |
let nodeModuleImports = [ | ||
`import { NgModule } from '@angular/core';`, | ||
`import { CommonModule } from '@angular/common';`, | ||
`import { HttpModule } from '@angular/http';`, | ||
`import { FormsModule, ReactiveFormsModule } from '@angular/forms';`, | ||
`import { RouterModule } from '@angular/router';`, | ||
`import { SkyAppAssetsService } from '@skyux/assets';`, | ||
|
@@ -93,7 +92,6 @@ function getSource(skyAppConfig) { | |
|
||
let runtimeModuleImports = [ | ||
'CommonModule', | ||
'HttpModule', | ||
'FormsModule', | ||
'ReactiveFormsModule', | ||
'AppExtrasModule', | ||
|
@@ -123,16 +121,6 @@ function getSource(skyAppConfig) { | |
|
||
runtimeProviders.push(authTokenProvider); | ||
|
||
if (skyAppConfig.skyux.auth) { | ||
nodeModuleImports.push(`import { XHRBackend, RequestOptions } from '@angular/http';`); | ||
nodeModuleImports.push(`import { SkyAuthHttp } from '@skyux/http';`); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sayonara, See: https://github.com/blackbaud/skyux-http/blob/rc-4.0.0/CHANGELOG.md#400-rc0-2019-11-21 |
||
runtimeProviders.push(`{ | ||
provide: SkyAuthHttp, | ||
useClass: SkyAuthHttp, | ||
deps: [XHRBackend, RequestOptions, SkyAuthTokenProvider, SkyAppConfig] | ||
}`); | ||
} | ||
|
||
if (skyAppConfig.skyux.help) { | ||
nodeModuleImports.push(`import { BBHelpModule } from '@blackbaud/skyux-lib-help';`); | ||
runtimeModuleImports.push('BBHelpModule'); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This rule was turned "on" by default in the latest version of ESLint.