This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
[rc] Use dart-sass instead of node-sass
#157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## rc-4.0.0 #157 +/- ##
=======================================
Coverage 100% 100%
=======================================
Files 58 58
Lines 1768 1768
Branches 255 255
=======================================
Hits 1768 1768
Continue to review full report at Codecov.
|
Blackbaud-SteveBrush
requested review from
Blackbaud-PaulCrowder and
Blackbaud-BobbyEarl
Blackbaud-BobbyEarl
previously approved these changes
Sep 4, 2019
Blackbaud-SteveBrush
changed the title
dart-sass instead of node-sassdart-sass instead of node-sass
Blackbaud-SteveBrush
changed the title
dart-sass instead of node-sassdart-sass instead of node-sass
Blackbaud-SteveBrush
dismissed
Blackbaud-BobbyEarl’s stale review
via
2cc3078
|
Am I correct in my understanding that |
|
@Blackbaud-BobbyEarl Correct. |
Blackbaud-BobbyEarl
approved these changes
Nov 20, 2019
Blackbaud-SteveBrush
added a commit
that referenced
this pull request
Jun 10, 2020
* [rc] Merge master (#180) * [rc] Upgrade karma and jasmine dependencies (#152) * [rc] Use `dart-sass` instead of `node-sass` (#157) ## Breaking changes: - Any usage of `/deep/` will fail to compile; should be replaced with the proprietary `:ng-deep`. * [rc] Added support for `ng-packagr` (#201) * [rc] Added support for Angular 9, TypeScript ~3.6 (#181) * Update package.json/changelog for 4.0.0-rc.0 release (#211) * [rc] Update `@skyux/config`; style sheet injection (#212) * Update changelog/package.json for 4.0.0-rc.1 release (#213) * Update changelog/package.json for 4.0.0-rc.1 release * Doc tweaks Co-authored-by: John Lyons <[email protected]> * Rc 4.0.0 latest master 2020 02 20 (#217) * [rc] Enable Ivy; drop RxJS 5 (#218) * [rc] Update changelog/package.json for 4.0.0-rc.2 release (#219) * Update changelog/package.json for 4.0.0-rc.2 release * Updated changelog * [rc] Upgrade dependencies; merge master (#222) * [rc] Upgrade dependencies * Added babel loader. Targeting only ansi-regex and strip-ansi packages in node_modules (#221) * Added babel loader. Targeting specifically for ansi-regex package in node_modules. * Added test. * Added `strip-ansi` to known packages. * Updated for 3.15.2 (#223) * Updated for 3.15.2 * Incorporated feedback * Wording tweak Co-authored-by: John Lyons <[email protected]> Co-authored-by: Bobby Earl <[email protected]> Co-authored-by: John Lyons <[email protected]> * Updated changelog/package.json for 4.0.0-rc.3 release * [rc] Make `@skyux-sdk/pact` optional (#224) * [rc] Upgraded dependencies; merged master (#236) * Updated changelog/package.json for 4.0.0-rc.4 release * [rc] Upgraded dependencies (#238) * Updated changelog/package.json for 4.0.0-rc.5 release * [rc] Merge master, upgrade dependencies (#244) * Updated changelog/package.json for 4.0.0-rc.6 release * [rc] Use `public_api.ts` for libraries (#248) * [rc] Update changelog/package.json for 4.0.0-rc.7 release (#250) * Fixed test warning * [rc] Upgrade dependencies (#253) * Updated changelog/package.json for 4.0.0-rc.8 release * [rc] Upgraded help-client; dependencies (#254) * [rc] Upgrade dependencies * Upgrade packages * Fix dependencies * Updated changelog/package.json for 4.0.0-rc.9 release * Initialize theme service with theme mapped to current service ID (#255) * [rc] Upgraded dependencies (#257) * Added babel loader. Targeting only ansi-regex and strip-ansi packages in node_modules (#221) * Added babel loader. Targeting specifically for ansi-regex package in node_modules. * Added test. * Added `strip-ansi` to known packages. * Updated for 3.15.2 (#223) * Updated for 3.15.2 * Incorporated feedback * Wording tweak Co-authored-by: John Lyons <[email protected]> * Add viewport margin top for viewkeeper when omnibar enabled (#227) * Updated CHANGELOG and package.json for 3.16.0 release (#228) * Updated CHANGELOG and package.json for 3.16.0 release * Tweaked CHANGELOG entry * Setting pathMatch property on redirects. (#230) * Updated CHANGELOG and package files for 3.16.1. (#231) * Updated CHANGELOG and package files for 3.16.1. * Incorporated feedback. * Updated babel. (#234) * Updated files for 3.16.2. (#235) * Bump minimist from 1.2.0 to 1.2.2 (#232) Bumps [minimist](https://github.com/substack/minimist) from 1.2.0 to 1.2.2. - [Release notes](https://github.com/substack/minimist/releases) - [Commits](https://github.com/substack/minimist/compare/1.2.0...1.2.2) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update license (#241) Updated license date to address blackbaud/skyux2-docs#894 * Added theming support (#242) Co-authored-by: Steve Brush <[email protected]> * Updated CHANGELOG and package.json for 3.17.0 release (#243) * [rc] Upgrade dependencies; merge master * Fix test * Fix peers * Upgrade auth-client Co-authored-by: Bobby Earl <[email protected]> Co-authored-by: John Lyons <[email protected]> Co-authored-by: Paul Crowder <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Denise Pena <[email protected]> * Updated changelog/package.json for 4.0.0-rc.10 release * [rc] Improve AoT bundle size (#258) * Updated changelog/package.json for 4.0.0-rc.11 release * [rc] Merge master; upgrade dependencies (#263) * [rc] Merge master * Upgrade packages * Upgrade testing lib * Updated changelog/package.json for 4.0.0-rc.12 release * [rc] Upgrade Protractor (#264) * [rc] Merge master (#266) * Updated changelog/package.json for 4.0.0-rc.13 release * Updated changelog/package.json for 4.0.0-rc.14 release * [rc] Upgraded dependencies (#271) * Updated changelog/package.json for 4.0.0-rc.15 release * [rc] Upgraded dependencies (#273) * Added `no-unused-variable` to `tslint.json` (#277) * Updated changelog/package.json for 4.0.0-rc.16 release * Adjustments * Change date * Wording tweak * Fix typo * Wording tweak * Add missing articles * Fix changelog Co-authored-by: Erika McVey <[email protected]> Co-authored-by: John Lyons <[email protected]> Co-authored-by: Bobby Earl <[email protected]> Co-authored-by: Paul Crowder <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Denise Pena <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why Dart?
https://github.com/sass/dart-sass#why-dart
Angular CLI uses Dart now, instead of Node SASS.
Breaking changes:
/deep/selector. Angular has already deprecated that selector, but we'll need to release this pull request in a breaking change of Builder.Angular 8 made this a deliberate breaking change, so when we adopt Angular 8, this will be a natural update to Builder: angular/angular#30815