[audit2] #12 Remove reverse claiming from EARegistrarController #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 22, 2024
cb-elileers
approved these changes
Jul 23, 2024
stevieraykatz
added a commit
that referenced
this pull request
Jul 24, 2024
* [audit2] #2 Typos and Documentation (#72) * Fix typo in PaymentReceiverUpdated * Fix typo in L2Resolver commment * Fix typos in L2Resolver and ReverseRegistrar natspec * Fix comment in IPriceOracle * Fix natspec in controllers * Remove unused event (#71) * [audit2] #4 Cleanup GRACE_PERIOD handling for launch auction (#73) * Cleanup GRACE_PERIOD handling for launch auction * Add GRACE_PERIOD to EARegistrarController * [audit2] #5 Explicitly declare state visibility (#75) * Explicitly declare state visibility * Style guide * Change resolver for reverse node when changing default resolver (#76) * Remove reverse claiming from EARegistrarController (#78) * Add IExtendedResolver supported signal for L2Resolver (#77) * Add reverse node claim to L2 Resolver (#81) * [audit2] #6 Remove addr.reverse setting from ReverseRegistrar (#74) * Remove addr.reverse setting from ReverseRegistrar * Address PR suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the EA Registrar Controller will be a short-lived contract, opt out of claiming the reverse node.
From spearbit:
Null value is set as the resolver of reverse records for EARegistrarController
Status: New
Severity: Informational
AkshaySrivastav
AkshaySrivastav
created on Jul 22, 2024 at 06:17
Description
The constructor of EARegistrarController performs the IReverseRegistrar.claim call to claim its reverse records.
By analysing the deployment sequence of protocol contracts and the provided integration tests it can be seen that during the deployment of EARegistrarController the ReverseRegistrar::defaultResolver state variable is address(0) (as the default L2Resolver is not deployed yet). Hence the resolver of reverse records for EARegistrarController is set to address(0).
Assuming that the RegistrarController will be deployed after early registration period, this issue should not impact RegistrarController.
Recommendation
Make sure the owner of EARegistrarController manually sets the resolver of reverse records for EARegistrarController after protocol deployment.