Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[audit2] #12 Remove reverse claiming from EARegistrarController #78

Merged
merged 1 commit into from
Jul 23, 2024
Merged

[audit2] #12 Remove reverse claiming from EARegistrarController #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions src/L2/EARegistrarController.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,8 +257,6 @@ contract EARegistrarController is Ownable {

/// @notice Registrar Controller construction sets all of the requisite external contracts.
///
/// @dev Assigns ownership of this contract's reverse record to the `owner_`.
///
/// @param base_ The base registrar contract.
/// @param prices_ The pricing oracle contract.
/// @param reverseRegistrar_ The reverse registrar contract.
Expand All @@ -281,7 +279,6 @@ contract EARegistrarController is Ownable {
rootName = rootName_;
paymentReceiver = paymentReceiver_;
_initializeOwner(owner_);
reverseRegistrar.claim(owner_);
}

/// @notice Allows the `owner` to set discount details for a specified `key`.
Expand Down
1 change: 0 additions & 1 deletion test/EARegistrarController/EARegistrarControllerBase.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ contract EARegistrarControllerBase is Test {
function test_controller_constructor() public view {
assertEq(address(controller.prices()), address(prices));
assertEq(address(controller.reverseRegistrar()), address(reverse));
assertTrue(reverse.hasClaimed(owner));
assertEq(controller.owner(), owner);
assertEq(controller.rootNode(), rootNode);
assertEq(keccak256(bytes(controller.rootName())), keccak256(bytes(rootName)));
Expand Down