[audit2] #11 Add reverse node claim to L2 Resolver

[stevieraykatz]

From spearbit:

Missing explicitly claiming the reverse resolution record for L2Resolver
Status: New
Severity: Informational
AkshaySrivastav
AkshaySrivastav

created on Jul 22, 2024 at 05:52
Description
The current implementation of L2Resolver contract does not claim the reverse resolution record for itself explicitly.

Ideally just like RegistrarController, EARegistrarController & ENS's PublicResolver reverse record should be explicitly claimed for L2Resolver during its construction.

Recommendation
Add the IReverseRegistrar.claim call in L2Resolver::constructor:

    constructor(ENS ens_, address registrarController_, address reverseRegistrar_, address owner_) {
        ens = ens_;
        registrarController = registrarController_;
        reverseRegistrar = reverseRegistrar_;
        _initializeOwner(owner_);
+       IReverseRegistrar(reverseRegistrar).claim(owner_);
    }

[akshaysrivastav]

It'd have been nice if a test case validated that owner record of L2Resolver returns the admin's address
@stevieraykatz

[stevieraykatz]

@akshaysrivastav I can add that