Merge master to WebStorm #1120
Merged
Merge master to WebStorm #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d in the project. (#1029)
* Fix the refresh vfs in ReadAction bug. * Use sam build folder to avoid recursive copying.
…button (#896) * Resolve some TODOs to simplify the LambdaBuilder logic * Make sure all exceptions get mapped into CompletableFuture.completeExceptionally
#1056) * Enable using the presence of a requirements.txt to determine if a method is a handler in Python * This allows us to not rely on source roots but instead matches what SAM build will do, which is look for the requirements.txt at the codeUri location * Fix broken test that had incorrect assertion and behavior * Fix tests not testing the correct things
* It kept having aliasing issues related to editing a cloned run config * It kept us from 192 due to NoSuchMethod error
…#1077) - Fix exception on startup while gathering SAM CLI information; replace synchronous execution on EDT with modifying project model after project is initialized - Fix validation for template.yaml file to be able to call SAM deploy action - Fix sync calls on run configuration validation to use async calls - Add tests to verify SamVersion evaluation and getFileInfo logic
…ck (#1079) * Move test back to unit test package * Make FileInfoCache async based * Move logic up from SAM version cache to FileInfoCache * Tweak the evaluateBlocking to throw if not successful * Move tests around and update to match the current state of the world
* This allows tests to run with Java 11 or Java 8
* Refresh Vfs after project is updated from SAM CLI to sync it with File System * WriteAction is not necessary while SAM project is generated since there is no interaction with VFS. We refresh VFS after files are copied.
* Revert "Revert "Enable toolkit in 192 (#1000)" (#1007)" This reverts commit fcdfa2c. * Remove warning around state variable name * Make sure Java lambdas tests compile as 1.8 * Fix incompatible plugin versions * Suppress and comment deprecation * Fix SAM SemVer tests since now 192 cares about things after the patch version
* Push coverage to CodeCov
* Add test artifact saving for linux-based CI jobs
* No functional changes were made
…1096) * This pushes the network call itself to a background thread while showing a progress bar that we are doing something. This is what is suggested by https://github.com/JetBrains/intellij-community/blob/62d0e1a5010fef3369d91b670a3cc7b11ac73ba1/platform/platform-api/src/com/intellij/execution/process/OSProcessHandler.java#L105
* Fix the ui tests since 192 changes JBTabs to a brand new system
* In 192, we were showing that we were triggering reentrant indexing. Since we only use this for Java handler completion, we will remove it.
* Add library test in Gradle UI test and change the importing behavior to background async.
…1110) * JetBrain's Invoker is forced to run under a read action, fork the Invoker and AsyncTreeModel (and supporting classes) to remove that requirement * Increase min version to drop 183 EAP builds, implement abstract method that wasnt implemented in earlier versions
Codecov Report
@@ Coverage Diff @@
## feature/webstorm-support #1120 +/- ##
==============================================================
+ Coverage 44.21% 45.72% +1.51%
- Complexity 546 662 +116
==============================================================
Files 172 187 +15
Lines 5625 7127 +1502
Branches 729 975 +246
==============================================================
+ Hits 2487 3259 +772
- Misses 2897 3509 +612
- Partials 241 359 +118
Continue to review full report at Codecov.
|
Closed
kiiadi
approved these changes
Jul 30, 2019
Will-ShaoHua
added a commit
to Will-ShaoHua/aws-toolkit-jetbrains
that referenced
this pull request
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Motivation and Context
Related Issue(s)
Testing
Screenshots (if appropriate)
Checklist
gradlew checksucceedsLicense
I confirm that my contribution is made under the terms of the Apache 2.0 license.