Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging from master #1122

Closed

Conversation

kiiadi
Copy link
Contributor

@kiiadi kiiadi commented Jul 30, 2019

No description provided.

abrooksv and others added 30 commits June 6, 2019 16:21
* Fix the refresh vfs in ReadAction bug.
* Use sam build folder to avoid recursive copying.
* Linux unit tests enable local caches
* Linux integration tests use 2.0 image, and apt install python instead of compiling
* Make sure CI is set on all builds
* Add console plain, since console doesnt support ANSI codes
* Show error message nicely when AWS credential file is not valid instead of erroring out.
…button (#896)

* Resolve some TODOs to simplify the LambdaBuilder logic
* Make sure all exceptions get mapped into CompletableFuture.completeExceptionally
#1056)

* Enable using the presence of a requirements.txt to determine if a method is a handler in Python

* This allows us to not rely on source roots but instead matches what SAM build will do, which is look for the requirements.txt at the codeUri location
* Fix broken test that had incorrect assertion and behavior
* Fix tests not testing the correct things
abrooksv and others added 22 commits July 16, 2019 10:09
* Add test artifact saving for linux-based CI jobs
* No functional changes were made
* Fix the ui tests since 192 changes JBTabs to a brand new system
* In 192, we were showing that we were triggering reentrant indexing. Since we only use this for Java handler completion, we will remove it.
* 2.7.x introduces a new Apache version. This version of Apache breaks URLs that have no path, but have query parameters.
* Add library test in Gradle UI test and change the importing behavior to background async.
…1110)

* JetBrain's Invoker is forced to run under a read action, fork the Invoker and AsyncTreeModel (and supporting classes) to remove that requirement
* Increase min version to drop 183 EAP builds, implement abstract method that wasnt implemented in earlier versions
@kiiadi kiiadi requested a review from a team as a code owner July 30, 2019 20:51
@zhangzhx
Copy link
Contributor

I already had a PR for this #1120

@kiiadi kiiadi force-pushed the kiiadi/merge-webstorm-from-master branch from d1c2c30 to a5990c6 Compare July 30, 2019 21:02
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (feature/webstorm-support@579c54e). Click here to learn what that means.
The diff coverage is 47.3%.

Impacted file tree graph

@@                     Coverage Diff                     @@
##             feature/webstorm-support    #1122   +/-   ##
===========================================================
  Coverage                            ?   45.35%           
  Complexity                          ?      655           
===========================================================
  Files                               ?      185           
  Lines                               ?     6544           
  Branches                            ?      973           
===========================================================
  Hits                                ?     2968           
  Misses                              ?     3214           
  Partials                            ?      362
Flag Coverage Δ Complexity Δ
#unittest 45.35% <47.3%> (?) 655 <159> (?)
Impacted Files Coverage Δ Complexity Δ
...etbrains/core/explorer/AwsExplorerTreeStructure.kt 0% <ø> (ø) 0 <0> (?)
...ts/jetbrains/services/lambda/LambdaBuilderUtils.kt 9.09% <ø> (ø) 2 <0> (?)
...ftware/aws/toolkits/jetbrains/ui/RegionSelector.kt 0% <ø> (ø) 0 <0> (?)
...olkits/jetbrains/services/lambda/sam/SamOptions.kt 100% <ø> (ø) 4 <0> (?)
...ws/toolkits/jetbrains/core/DeleteResourceAction.kt 0% <ø> (ø) 0 <0> (?)
.../jetbrains/core/explorer/AwsExplorerTreeBuilder.kt 0% <ø> (ø) 0 <0> (?)
...rc/software/aws/toolkits/core/region/Partitions.kt 68% <ø> (ø) 2 <0> (?)
...ices/cloudformation/CloudFormationTemplateIndex.kt 91.83% <ø> (ø) 9 <0> (?)
...oolkits/jetbrains/core/explorer/AbstractActions.kt 0% <ø> (ø) 0 <0> (?)
...ains/services/lambda/upload/EditFunctionPanel.java 100% <ø> (ø) 5 <0> (?)
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 579c54e...a5990c6. Read the comment docs.

@kiiadi kiiadi closed this Jul 30, 2019
@kiiadi kiiadi deleted the kiiadi/merge-webstorm-from-master branch August 20, 2019 05:49
Will-ShaoHua pushed a commit to Will-ShaoHua/aws-toolkit-jetbrains that referenced this pull request Mar 17, 2023
* API rename

* Add optout header to new GenerateCompletions API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants