Re-enable 192 EAP #1076

abrooksv · 2019-07-04T00:47:56Z

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Description

Motivation and Context

Related Issue(s)

Testing

ALTERNATIVE_IDE_PROFILE_NAME=2018.3 ./gradlew integrationTest check
ALTERNATIVE_IDE_PROFILE_NAME=2019.2 ./gradlew integrationTest check

Screenshots (if appropriate)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

codecov-io · 2019-07-04T00:56:38Z

Codecov Report

Merging #1076 into master will not change coverage.
The diff coverage is 88.57%.

@@            Coverage Diff            @@
##             master    #1076   +/-   ##
=========================================
  Coverage     45.96%   45.96%           
  Complexity      562      562           
=========================================
  Files           167      167           
  Lines          5561     5561           
  Branches        711      711           
=========================================
  Hits           2556     2556           
  Misses         2775     2775           
  Partials        230      230

Flag	Coverage Δ	Complexity Δ
#unittest	`45.96% <88.57%> (ø)`	`562 <31> (ø)`	⬇️

Impacted Files	Coverage Δ	Complexity Δ
...vices/lambda/execution/remote/RemoteLambdaState.kt	`60.41% <ø> (ø)`	`5 <0> (ø)`	⬇️
...kits/jetbrains/core/explorer/ExplorerToolWindow.kt	`0% <ø> (ø)`	`0 <0> (ø)`	⬇️
...ion/remote/LambdaRemoteRunConfigurationProducer.kt	`56.25% <ø> (ø)`	`2 <0> (ø)`	⬇️
...ices/cloudformation/CloudFormationTemplateIndex.kt	`91.83% <ø> (ø)`	`9 <0> (ø)`	⬇️
.../jetbrains/core/explorer/AwsExplorerTreeBuilder.kt	`0% <ø> (ø)`	`0 <0> (ø)`	⬇️
...ts/jetbrains/services/lambda/LambdaBuilderUtils.kt	`9.09% <ø> (ø)`	`2 <0> (ø)`	⬇️
...ftware/aws/toolkits/jetbrains/ui/RegionSelector.kt	`0% <ø> (ø)`	`0 <0> (ø)`	⬇️
...tbrains/services/lambda/upload/LambdaLineMarker.kt	`75% <ø> (ø)`	`15 <0> (ø)`	⬇️
...oolkits/jetbrains/ui/CredentialProviderSelector.kt	`0% <ø> (ø)`	`0 <0> (ø)`	⬇️
...ces/lambda/execution/LambdaRunConfigurationBase.kt	`78.78% <100%> (ø)`	`21 <8> (ø)`	⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80ec85e...e9ef891. Read the comment docs.

zhangzhx · 2019-07-04T01:56:27Z

intellijJVersions.gradle

@@ -12,7 +12,7 @@ static def ideProfiles() {
                            ]
                    ]
            ],
-            "2019.1": [
+            "2019.1": [ // TODO: Marker comment: FIX_WHEN_MIN_IS_192


Do we need to mark 183 as well?

We will probably remove 183 at same time as 191

OK. I think one marker is enough then.

This reverts commit fcdfa2c.

… version

* Revert "Revert "Enable toolkit in 192 (#1000)" (#1007)" This reverts commit fcdfa2c. * Remove warning around state variable name * Make sure Java lambdas tests compile as 1.8 * Fix incompatible plugin versions * Suppress and comment deprecation * Fix SAM SemVer tests since now 192 cares about things after the patch version

* Switch out our test logger (#1027) * Fixing alternative IDE logic so that it runs for every runTask defined in the project. (#1029) * Refactor New Project Wizard to extensions to support other platforms (#1022) * Fix the bug when project is not located in the same drive of temp fol… (#1034) * Fix the refresh vfs in ReadAction bug. (#1060) * Fix the refresh vfs in ReadAction bug. * Use sam build folder to avoid recursive copying. * Fix exceptions thrown in a run config breaking the Run Config action button (#896) * Resolve some TODOs to simplify the LambdaBuilder logic * Make sure all exceptions get mapped into CompletableFuture.completeExceptionally * Enable using the presence of a requirements.txt to determine if a met… (#1056) * Enable using the presence of a requirements.txt to determine if a method is a handler in Python * This allows us to not rely on source roots but instead matches what SAM build will do, which is look for the requirements.txt at the codeUri location * Fix broken test that had incorrect assertion and behavior * Fix tests not testing the correct things * Fix dynamodb template for python not creating successfully. (#1071) * Remove anonymized. (#1074) * Only build the specified lambda function when running/debugging from (#1075) * Remove the BaseState system from run configs (#1073) * It kept having aliasing issues related to editing a cloned run config * It kept us from 192 due to NoSuchMethod error * Fix exceptions while generating projects and on run config validation (#1077) - Fix exception on startup while gathering SAM CLI information; replace synchronous execution on EDT with modifying project model after project is initialized - Fix validation for template.yaml file to be able to call SAM deploy action - Fix sync calls on run configuration validation to use async calls - Add tests to verify SamVersion evaluation and getFileInfo logic * Fix LocalLambdaRunConfiguration tests broken by async SAM version check (#1079) * Move test back to unit test package * Make FileInfoCache async based * Move logic up from SAM version cache to FileInfoCache * Tweak the evaluateBlocking to throw if not successful * Move tests around and update to match the current state of the world * Switch UI tests to use a regex for SDK selection (#1084) * This allows tests to run with Java 11 or Java 8 * Fix Virtual File System refresh after new project is generated (#1083) * Refresh Vfs after project is updated from SAM CLI to sync it with File System * WriteAction is not necessary while SAM project is generated since there is no interaction with VFS. We refresh VFS after files are copied. * Re-enable 192 EAP (#1076) * Revert "Revert "Enable toolkit in 192 (#1000)" (#1007)" This reverts commit fcdfa2c. * Remove warning around state variable name * Make sure Java lambdas tests compile as 1.8 * Fix incompatible plugin versions * Suppress and comment deprecation * Fix SAM SemVer tests since now 192 cares about things after the patch version * Fix toString() on SDK choices in UI test framework (#1085) * Fix Java UI tests on 2018.3 (#1086) * Fix read/write action errors when invoking a SAM lambda (#1087) * Fix Windows SAM detection tests not running on Windows (#1089) * Push coverage to CodeCov * Add test artifact saving for linux-based CI jobs (#1088) * Add test artifact saving for linux-based CI jobs * Backfill credential management document (#1055) * Break up the AwsExplorerNodes (#1091) * No functional changes were made * Remove unused code (#1093) * Wrap credential retrieving with progress indication if on UI thread (#1096) * This pushes the network call itself to a background thread while showing a progress bar that we are doing something. This is what is suggested by https://github.com/JetBrains/intellij-community/blob/62d0e1a5010fef3369d91b670a3cc7b11ac73ba1/platform/platform-api/src/com/intellij/execution/process/OSProcessHandler.java#L105 * Remove the endpoints.json URL that does not use HTTPS (#1097) * Add changelog for #1096 (#1098) * Pull in latest AWS SDK to update Lambda models (#1100) * Simplify explorer service node (#1092) * Rename some of the local and remote lambda class names to be more consistent. (#1101) * Update to stable 192 versions, fix UI tests (#1106) * Fix the ui tests since 192 changes JBTabs to a brand new system * Remove LambdaHandlerIndex (#1107) * In 192, we were showing that we were triggering reentrant indexing. Since we only use this for Java handler completion, we will remove it. * Updating version to 1.5 * Updating SNAPSHOT version to 1.6-SNAPSHOT * Fix Create Lambda action missing from explorer menu (#1111) * Implement resource cache - to be used for caching describe calls. (#1102) * Support Gradle link (#1080) * Add library test in Gradle UI test and change the importing behavior to background async. * Fork JetBrains' AsyncTreeModel to remove the read action requirement (#1110) * JetBrain's Invoker is forced to run under a read action, fork the Invoker and AsyncTreeModel (and supporting classes) to remove that requirement * Increase min version to drop 183 EAP builds, implement abstract method that wasnt implemented in earlier versions * Add IU 192 profile

* Revert "Revert "Enable toolkit in 192 (#1000)" (#1007)" This reverts commit fcdfa2c. * Remove warning around state variable name * Make sure Java lambdas tests compile as 1.8 * Fix incompatible plugin versions * Suppress and comment deprecation * Fix SAM SemVer tests since now 192 cares about things after the patch version

* (feat codewhisperer) bump ideProfilename (aws#988) * bump ideProfilename * *update codewhisperer service model and bump sdk version (aws#991) * update cwspr model v2 (aws#1001) * Cwspr sso client adaptor (aws#995) * cwspr login dialog prototype (aws#990) * fix not IAM comment not grayed out (aws#1006) * cwspr nodes UX update (aws#1005) * Cwspr setting panel grayout (for sso user) (aws#1000) * fix transformation (aws#1009) * (feat codewhisperer) credentail impl (aws#1003) * remove all usage of clientManager.getClient (aws#1015) * update codewhisperer model -- reference filter (aws#1020) * remove accountless token ux compoentns (aws#1013) * merge conflict resolve * (feat codewhisperer) remove reference filter logic (aws#1017) * (feat codewhisperer) remove codewhisperer from toolkit experimental feature (aws#1018) * empty commit to trigger build * (feat codewhisperer) credential flow integration (aws#1014) * fix compile error caused by missing * Some adaption to new auth logic from Toolkit * adapt to Toolkit's bearer credential flow * update test case for connectionSettings() and some cleanup * detekt fix * Remove accidentally added changes * (codewhisperer) cleanup and chores (aws#1037) * clean up codewhisperer constants duplicate Sono/Sso settings * remove redundant logics in codewhispererEndpointCustomizer * add logic to handle user choose SSO login with AWS ID url * Fix CodeWhispererCredentialManagerTest * (codewhisperer) fix bugs (aws#1039) * (codewhisperer) codewhisperer usage limit hit for free tier users UX flow (aws#1044) * finish indifividual UX components for usage limit hit case, integration[WIP] * initial commits of usage limit UX components, integration logics[WIP] * add UX integration * add notificationError and todos * add back deleted import * small fix -- only show error message on manual trigger * (codewhisperer) access notification and logics implementation (aws#1041) * accless notification and logics impmlementation * address comments * update timer API usage * detekt fix * small fix * small fix * small tweak to prevent listener get installed > 1 times * detekt fix * Update How to user CodeWhisperer markdown (aws#1060) * Use local gif for HowToUseCodeWhisperer (aws#1063) * (codewhisperer) integration with new Toolkit API, UX (profile switcher, logout) (aws#1055) * Only show the hint text when CodeWhisperer is using secondary connection (aws#1068) * update accless expiration date (aws#1073) * (codewhisperer) several small fix (aws#1070) * * Toolkit SSO action grouop help action imple * show toast infomation when user ack codewhisperer to keep using SSO connection in the background * small fix * localize redirect URL * fix typo Co-authored-by: andrewyuq <[email protected]> * (codewhisperer) sso display name (aws#1074) * sso display name * updade display format * both SSO/Sono will show Connected with... Co-authored-by: andrewyuq <[email protected]> * (codewhisperer) fix test class CodeWhispererClientTest (aws#1072) * fix test class CodeWhispererClientTest * * fix sigv4 client pointing to gamma * add comment * fix naming convention Co-authored-by: andrewyuq <[email protected]> * (codewhisperer) add telemetry for login click events (aws#1081) * (codewhisperer) SSO connection expire fix (aws#1075) * fix when SSO connection expires, login will never try reauth and return the same one * fix broken test * update comment * Addressing the comment * Fix tests Co-authored-by: andrewyuq <[email protected]> Co-authored-by: yuxqiang <[email protected]> * (codewhisperer) fix broken code scan test class (aws#1069) * fix broken test cases * revert change added accidentally * detekt fix Co-authored-by: andrewyuq <[email protected]> Co-authored-by: Richard Li <[email protected]> * (feat codewhisperer) sso ux tooltip (aws#989) * cwspr tooltip * anchor tooltip location to dev tool tab component * remove TODO * detekt fix * replace description text * Update jetbrains-core/src/software/aws/toolkits/jetbrains/core/explorer/AwsToolkitExplorerToolWindow.kt Co-authored-by: Richard Li <[email protected]> * Address comments Co-authored-by: yuxqiang <[email protected]> Co-authored-by: andrewyuq <[email protected]> Co-authored-by: Richard Li <[email protected]> * (codewhisperer) UX improvement SSO expire (aws#1076) * when user try to reauth with given conneciton, fill in the required metadata in the login dialog for users * detekt fix * detekt fix * NPE fix * detekt fix * when user try to reauth with given conneciton, fill in the required metadata in the login dialog for users * detekt fix * detekt fix * NPE fix * detekt fix * Address comments * Sneak in two text changes * One more text change Co-authored-by: andrewyuq <[email protected]> Co-authored-by: yuxqiang <[email protected]> * Fix test integration failures Co-authored-by: aws-toolkit-automation <43144436+aws-toolkit-automation@users.noreply.github.com> Co-authored-by: Will Lo <[email protected]> Co-authored-by: Shao-Hua Lo <[email protected]> Co-authored-by: Richard Li <[email protected]> Co-authored-by: Richard Li <[email protected]>

abrooksv requested a review from a team as a code owner July 4, 2019 00:47

abrooksv changed the title ~~Abrooksv readd192~~ Re-enable 192 EAP Jul 4, 2019

zhangzhx approved these changes Jul 4, 2019

View reviewed changes

Austin Brooks added 6 commits July 8, 2019 09:13

Revert "Revert "Enable toolkit in 192 (#1000)" (#1007)"

eb4029b

This reverts commit fcdfa2c.

Remove warning around state variable name

c3b97e7

Make sure Java lambdas tests compile as 1.8

000f41c

Fix incompatible plugin versions

65119ab

Suppress and comment deprecations

81fa594

Fix SAM SemVer tests since now 192 cares about things after the patch…

4ab5f3e

… version

abrooksv force-pushed the abrooksv-readd192 branch from cb10639 to 4ab5f3e Compare July 8, 2019 16:14

abrooksv added 2 commits July 9, 2019 15:46

Merge branch 'master' into abrooksv-readd192

fdb0dc5

Merge branch 'master' into abrooksv-readd192

e9ef891

abrooksv merged commit 72ca1c9 into master Jul 11, 2019

abrooksv deleted the abrooksv-readd192 branch July 11, 2019 22:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Re-enable 192 EAP #1076

Re-enable 192 EAP #1076

abrooksv commented Jul 4, 2019

codecov-io commented Jul 4, 2019 •

edited

Loading

zhangzhx Jul 4, 2019

abrooksv Jul 8, 2019

zhangzhx Jul 8, 2019

Re-enable 192 EAP #1076

Re-enable 192 EAP #1076

Conversation

abrooksv commented Jul 4, 2019

Types of changes

Description

Motivation and Context

Related Issue(s)

Testing

Screenshots (if appropriate)

License

codecov-io commented Jul 4, 2019 • edited Loading

Codecov Report

zhangzhx Jul 4, 2019

Choose a reason for hiding this comment

abrooksv Jul 8, 2019

Choose a reason for hiding this comment

zhangzhx Jul 8, 2019

Choose a reason for hiding this comment

codecov-io commented Jul 4, 2019 •

edited

Loading