Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NodeJs SAM debugging #995

Merged
merged 1 commit into from
May 24, 2019

Conversation

zhangzhx
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

  • Support NodeJs SAM debugging
  • Add integration test output of jetbrains-core module to testJar as the ultimate module depends on it.

Motivation and Context

Related Issue(s)

#942

Testing

Screenshots (if appropriate)

Checklist

  • I have read the README document
  • I have read the CONTRIBUTING document
  • Local run of gradlew check succeeds
  • My code follows the code style of this project
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhangzhx zhangzhx requested a review from a team as a code owner May 24, 2019 20:09
@codecov-io
Copy link

Codecov Report

Merging #995 into feature/zhaoxiz-nodejs will decrease coverage by 0.16%.
The diff coverage is 8.33%.

Impacted file tree graph

@@                     Coverage Diff                      @@
##             feature/zhaoxiz-nodejs     #995      +/-   ##
============================================================
- Coverage                     44.29%   44.13%   -0.17%     
  Complexity                      509      509              
============================================================
  Files                           166      166              
  Lines                          5398     5418      +20     
  Branches                        689      691       +2     
============================================================
  Hits                           2391     2391              
- Misses                         2764     2784      +20     
  Partials                        243      243
Flag Coverage Δ Complexity Δ
#unittest 44.13% <8.33%> (-0.17%) 509 <0> (ø)
Impacted Files Coverage Δ Complexity Δ
...services/lambda/execution/local/SamRunningState.kt 12.5% <0%> (ø) 2 <0> (ø) ⬇️
...ns/services/lambda/nodejs/NodeJsSamDebugSupport.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
.../jetbrains/services/lambda/execution/PathMapper.kt 67.74% <100%> (ø) 9 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be34596...68622fb. Read the comment docs.

@zhangzhx zhangzhx merged commit a3707cb into feature/zhaoxiz-nodejs May 24, 2019
@abrooksv abrooksv deleted the zhaoxiz-nodejsDebugSupport branch May 29, 2019 16:38
zhangzhx added a commit that referenced this pull request Jun 4, 2019
Will-ShaoHua added a commit to Will-ShaoHua/aws-toolkit-jetbrains that referenced this pull request Mar 17, 2023
* (feat codewhisperer) bump ideProfilename (aws#988)

* bump ideProfilename

* *update codewhisperer service model and bump sdk version (aws#991)

* update cwspr model v2 (aws#1001)

* Cwspr sso client adaptor (aws#995)

* cwspr login dialog prototype (aws#990)

* fix not IAM comment not grayed out (aws#1006)

* cwspr nodes UX update (aws#1005)

* Cwspr setting panel grayout (for sso user) (aws#1000)

* fix transformation (aws#1009)

* (feat codewhisperer) credentail impl (aws#1003)

* remove all usage of clientManager.getClient (aws#1015)

* update codewhisperer model -- reference filter (aws#1020)

* remove accountless token ux compoentns (aws#1013)

* merge conflict resolve

* (feat codewhisperer) remove reference filter logic (aws#1017)

* (feat codewhisperer) remove codewhisperer from toolkit experimental feature (aws#1018)

* empty commit to trigger build

* (feat codewhisperer) credential flow integration  (aws#1014)

* fix compile error caused by missing

* Some adaption to new auth logic from Toolkit

* adapt to Toolkit's bearer credential flow

* update test case for connectionSettings() and some cleanup

* detekt fix

* Remove accidentally added changes

* (codewhisperer) cleanup and chores (aws#1037)

* clean up codewhisperer constants duplicate Sono/Sso settings
* remove redundant logics in codewhispererEndpointCustomizer
* add logic to handle user choose SSO login with AWS ID url

* Fix CodeWhispererCredentialManagerTest

* (codewhisperer) fix bugs (aws#1039)

* (codewhisperer) codewhisperer usage limit hit for free tier users UX flow (aws#1044)

* finish indifividual UX components for usage limit hit case, integration[WIP]

* initial commits of usage limit UX components, integration logics[WIP]

* add UX integration

* add notificationError and todos

* add back deleted import

* small fix -- only show error message on manual trigger

* (codewhisperer) access notification and logics implementation (aws#1041)

* accless notification and logics impmlementation

* address comments

* update timer API usage

* detekt fix

* small fix

* small fix

* small tweak to prevent listener get installed > 1 times

* detekt fix

* Update How to user CodeWhisperer markdown (aws#1060)

* Use local gif for HowToUseCodeWhisperer (aws#1063)

* (codewhisperer) integration with new Toolkit API, UX (profile switcher, logout) (aws#1055)

* Only show the hint text when CodeWhisperer is using secondary connection (aws#1068)

* update accless expiration date (aws#1073)

* (codewhisperer) several small fix (aws#1070)

* * Toolkit SSO action grouop help action imple
* show toast infomation when user ack codewhisperer to keep using SSO connection in the background
* small fix

* localize redirect URL

* fix typo

Co-authored-by: andrewyuq <[email protected]>

* (codewhisperer) sso display name (aws#1074)

* sso display name

* updade display format

* both SSO/Sono will show Connected with...

Co-authored-by: andrewyuq <[email protected]>

* (codewhisperer) fix test class CodeWhispererClientTest (aws#1072)

* fix test class CodeWhispererClientTest

* * fix sigv4 client pointing to gamma
* add comment
* fix naming convention

Co-authored-by: andrewyuq <[email protected]>

* (codewhisperer) add telemetry for login click events (aws#1081)

* (codewhisperer) SSO connection expire fix (aws#1075)

* fix when SSO connection expires, login will never try reauth and return the same one

* fix broken test

* update comment

* Addressing the comment

* Fix tests

Co-authored-by: andrewyuq <[email protected]>
Co-authored-by: yuxqiang <[email protected]>

* (codewhisperer) fix broken code scan test class (aws#1069)

* fix broken test cases

* revert change added accidentally

* detekt fix

Co-authored-by: andrewyuq <[email protected]>
Co-authored-by: Richard Li <[email protected]>

* (feat codewhisperer) sso ux tooltip  (aws#989)

* cwspr tooltip

* anchor tooltip location to dev tool tab component

* remove TODO

* detekt fix

* replace description text

* Update jetbrains-core/src/software/aws/toolkits/jetbrains/core/explorer/AwsToolkitExplorerToolWindow.kt

Co-authored-by: Richard Li <[email protected]>

* Address comments

Co-authored-by: yuxqiang <[email protected]>
Co-authored-by: andrewyuq <[email protected]>
Co-authored-by: Richard Li <[email protected]>

* (codewhisperer) UX improvement SSO expire (aws#1076)

* when user try to reauth with given conneciton, fill in the required metadata in the login dialog for users

* detekt fix

* detekt fix

* NPE fix

* detekt fix

* when user try to reauth with given conneciton, fill in the required metadata in the login dialog for users

* detekt fix

* detekt fix

* NPE fix

* detekt fix

* Address comments

* Sneak in two text changes

* One more text change

Co-authored-by: andrewyuq <[email protected]>
Co-authored-by: yuxqiang <[email protected]>

* Fix test integration failures

Co-authored-by: aws-toolkit-automation <43144436+aws-toolkit-automation@users.noreply.github.com>
Co-authored-by: Will Lo <[email protected]>
Co-authored-by: Shao-Hua Lo <[email protected]>
Co-authored-by: Richard Li <[email protected]>
Co-authored-by: Richard Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants