Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write run config from ui #261

Merged
merged 76 commits into from
Aug 12, 2020
Merged

Write run config from ui #261

merged 76 commits into from
Aug 12, 2020

Conversation

srggrs
Copy link
Contributor

@srggrs srggrs commented Aug 12, 2020

Close #238, fix #251

Please refer to #260 for history

srggrs added 30 commits July 23, 2020 10:57
* master: (30 commits)
  Added explicit is not None to if statement
  Reapplied line breaks
  Fix for #247
  Fixed number of relations query
  Fixed remaining col and idx names
  Changed name of mode to deruiter
  Update pipeline/pipeline/association.py
  Update pipeline/pipeline/association.py
  Update pipeline/pipeline/association.py
  Update pipeline/pipeline/association.py
  Changed contains siblings column to render bool
  fix query with no siblings
  remove annotate, use computed metrics in db
  add computation of sources metrics for UI
  add fields to sources for UI stats
  calculate nr images and sources, update run
  add nr images and sources fields to run, help txt
  Consistent trailing commas
  Fix lightcurve scaling with error bars (#199)
  Minor bug fix
  ...

# Conflicts:
#	pipeline/views.py
* master:
  justify center for maintainance message
  changed color of banner, added pipeline CSS
  add maintainance message based on a config var

# Conflicts:
#	static/css/pipeline.css
#	templates/base.html
@srggrs srggrs requested a review from ajstewart August 12, 2020 04:42
@ajstewart
Copy link
Contributor

@srggrs Minor comment on the job config form the Association Beam Width also needs to be greyed out if not De Ruiter (it is only used with the De Ruiter method).

I'm happy where this is at now apart from the file writing. If the solution to big jobs is to write it in the config yourself then I feel like we need to have the new line error fixed. I don't care about the line numbers, just so that it writes correctly.

ajstewart
ajstewart previously approved these changes Aug 12, 2020
Copy link
Contributor

@ajstewart ajstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the blocking off the Associated Beam Width is in place this is good to go!

* master:
  Removed <br> in favour of margins
  Regenerated migration file
  Added SNR storage and query

# Conflicts:
#	pipeline/migrations/0001_initial.py
@srggrs srggrs requested a review from ajstewart August 12, 2020 08:33
@srggrs srggrs merged commit e23ea1f into master Aug 12, 2020
@srggrs srggrs deleted the write-run-config-from-ui branch August 12, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web page run fails to load if no forced measurements parquets Display Run config in Run detail page
2 participants