Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

many-to-one association not following expected logic #247

Closed
ajstewart opened this issue Aug 3, 2020 · 0 comments · Fixed by #248
Closed

many-to-one association not following expected logic #247

ajstewart opened this issue Aug 3, 2020 · 0 comments · Fixed by #248
Assignees
@ajstewart
Labels
bug Something isn't working

Comments

@ajstewart
Copy link
Contributor

The example below shows a many-to-one association where the two sources in epoch 2 should both be matched with the single source in epoch 3.

Screen Shot 2020-08-03 at 18 29 22

Following the association logic we have implemented, this should spawn two unique sources that both trace back through the individual sources in epoch 2, as this diagram shows:

Screen Shot 2020-08-03 at 18 31 20

But instead forced fits have taken place forward in time and the measurements in these epochs have not been associated.
@ajstewart ajstewart added the bug Something isn't working label Aug 3, 2020
@ajstewart ajstewart self-assigned this Aug 3, 2020
ajstewart added a commit that referenced this issue Aug 3, 2020
@ajstewart
Fix for #247
1dfcd1f 
* Added extra sources created through relationships to the skyc1_srcs df.
This was referenced Aug 3, 2020
Merged
Closed
srggrs added a commit that referenced this issue Aug 4, 2020
@srggrs
Merge branch 'master' into write-run-config-from-ui
9f3660d 
* master: (30 commits)
  Added explicit is not None to if statement
  Reapplied line breaks
  Fix for #247
  Fixed number of relations query
  Fixed remaining col and idx names
  Changed name of mode to deruiter
  Update pipeline/pipeline/association.py
  Update pipeline/pipeline/association.py
  Update pipeline/pipeline/association.py
  Update pipeline/pipeline/association.py
  Changed contains siblings column to render bool
  fix query with no siblings
  remove annotate, use computed metrics in db
  add computation of sources metrics for UI
  add fields to sources for UI stats
  calculate nr images and sources, update run
  add nr images and sources fields to run, help txt
  Consistent trailing commas
  Fix lightcurve scaling with error bars (#199)
  Minor bug fix
  ...

# Conflicts:
#	pipeline/views.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajstewart ajstewart

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed many-to-one source association askap-vast/vast-pipeline
1 participant
@ajstewart