Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tool tips and units to write config form #256

Merged
merged 4 commits into from
Aug 11, 2020

Conversation

ajstewart
Copy link
Contributor

I've added information tool tips to the config form. And tidied up some of the value names.

Screen Shot 2020-08-10 at 14 05 30

Screen Shot 2020-08-10 at 14 05 45

@ajstewart ajstewart added the enhancement New feature or request label Aug 10, 2020
@ajstewart ajstewart requested a review from srggrs August 10, 2020 04:07
Copy link
Contributor

@srggrs srggrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are all the tooltips popping out automatically like https://getbootstrap.com/docs/4.0/components/tooltips/ or you need to click the icon?

@ajstewart
Copy link
Contributor Author

Are all the tooltips popping out automatically like https://getbootstrap.com/docs/4.0/components/tooltips/ or you need to click the icon?

You should only need to hover over. Clicking on one keeps it there until you click somewhere else.

@ajstewart ajstewart requested a review from srggrs August 10, 2020 06:54
Copy link
Contributor

@srggrs srggrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good!

@ajstewart ajstewart merged commit 97274c7 into write-run-config-from-ui Aug 11, 2020
@ajstewart ajstewart deleted the write-run-config-from-ui-tooltips branch August 11, 2020 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants