Add support for NanoPi R3S #7556
Conversation
github-actions
bot
added
size/large
|
More or less just a note for further improvements: OpenWRT also made adjustments to led and added some load balancing by setting openwrt/openwrt@2902b0a#diff-f9d4f9cb6007e346ac46a85b5e28121e8bd2b0b18c2f91f5eab28b28b443f425 |
|
Looks good. I guess the We need to add some bare-DT/bare-defconfig (thus avoiding null-patches) support to mainline (2024.x) u-boot; it is currently implemented for the vendor u-boot but not for mainline. Not your fault, of course, but I guess that would help borrowing patches from openwrt. |
|
I think its not worth bothering with |
|
Nobody is happy to do the hard work unless they are stealing absolutely everything. Not sure what advantages you see with Dietpi, but this is comparison from other angle: https://docs.armbian.com/#key-advantages tl;dr;
|
|
Still untested but well, screw it. New image for testing: https://fi.mirror.armbian.de/.testing/Armbian-unofficial_25.02.0-trunk_Nanopi-r3s_bookworm_edge_6.13.0-rc5_minimal.img.xz |
|
My current test results show that the indicator lights are abnormal. For each network port, only one of the two indicator lights turns on, while the other does not blink. The system indicator light on the machine itself remains constantly on, whereas on the official firmware, it blinks. Additionally, the WAN and LAN indicator lights on the official firmware turn green when a cable is inserted, but there is no response with your firmware. |
|
Show uart logs if possible. |
I am able boot from SD card with this image. But the SYS led is in red, no flashing. Other leds are off. |
|
Without logs there is nothing I can do. |
The image has been tested and can boot from both SD and eMMC. USB is functioning normally (speed not tested). The front indicators show only the SYS LED as constantly lit, while the LAN and WAN LEDs do not work. I have created a patch based on the kernel source provided by FriendlyARM. The main changes include modifications to the network port indicators and adjustments to the WAN's phy-mode, rx, and tx delay. |
|
Bootable from SD Card.
When trying sudo apt update and sudo apt upgrade, this is the error messages. I hope that helps!
|
No idea where that comes from. Unrelated to board support though.
These can be safely be ignored. Also I think a bunch of firmware files have been added to the firmware package quite recently.
Thanks. So overall it seems good enough for merge since it seems to boot. |
Source & credits https://patchwork.ozlabs.org/project/uboot/list/?series=438193 I still need to figure out how to convert a patch series from patchwork in a way so the build framework doesn't complain about headers and magic and whatever. So a few hundreds of header lines have been replaced with something generic. Applies and builds fine now against current stable v2024.10
|
Hm I must have made a mistake when applying the dts patch. Doesn't want to build. |
Looking forward to seeing a new build to test. |
|
Alright looks like the patch needs to be applied after all other patches....which is bad. Patches should not depend on each other. Due to the patch dependency described above this PR should not be merged until this is resolved. Needs somebody more experienced that me. |
It's bootable. SYS led is now flashing, still no WAN or LAN leds.
|
Yes, I have not yet fixed the front WAN and LAN indicator lights. |
|
@EvilOlaf |
|
Thanks. Locally applied Please test |
|
Could you research how to adapt the NanoPi R3S to the current kernel? I want a stable kernel. |
Using SD and eMMC for booting, as expected, the front WAN and LAN LEDs are working, and the indicator lights on the rear network ports are also functioning properly. |
|
I'd say its good now. Next step, once merged, I'd say is backport to 6.12 to provide LTS kernel with current. |
|
dmesg.txt |
EvilOlaf
added
Ready to merge
Description
This PR adds support for the NanoPi R3S SBC
https://www.friendlyelec.com/index.php?route=product/product&product_id=303
u-boot patchset borrowed from OpenWRT
Linux dts backported from 6.13
How Has This Been Tested?
Whoever has this board and want to test, plz do and give feedback.
https://fi.mirror.armbian.de/.testing/Armbian-unofficial_24.11.0-trunk_Nanopi-r3s_bookworm_edge_6.12.3_minimal.img.xzImage with the updated u-boot patchset check comments below
Checklist: