[Table Vis]Switch to the new table plugin #8446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristw
reviewed
Oct 24, 2019
kristw
approved these changes
Oct 24, 2019
|
So excited!!! |
etr2460
reviewed
Oct 24, 2019
|
@etr2460. Will get some screenshot for the test cases I did. |
Codecov Report
@@ Coverage Diff @@
## master #8446 +/- ##
=======================================
Coverage 66.61% 66.61%
=======================================
Files 449 449
Lines 22610 22610
Branches 2367 2367
=======================================
Hits 15061 15061
Misses 7411 7411
Partials 138 138
Continue to review full report at Codecov.
|
|
@conglei There seems to be an issue with your lock file. |
|
Looking |
|
woo hoo |
|
I don't have the permission to merge .. |
graceguo-supercat
pushed a commit
that referenced
this pull request
Nov 13, 2019
* use new table comp * remove commented code * update lock file * fix lint * bump version * update lock file * fix lock issue
12 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
This PR is to use the new Table plugin to improve the rendering performance. The new plugin is built based on
react-virtualized.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION
REVIEWERS
@kristw