Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table Vis]Revert tablevis #8515

Merged
merged 1 commit into from
Nov 6, 2019
Merged

Conversation

conglei
Copy link
Contributor

@conglei conglei commented Nov 6, 2019

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

This PR is to revert the previous change #8446

After testing, we found that we need to fix several issues:

  1. better calculation of the column width;
  2. lexicographically sorting strings;
  3. fixing word truncating issues for extremely long word.
  4. performance improvement

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@conglei conglei changed the title revert tablevis [Table Vis]Revert tablevis Nov 6, 2019
@codecov-io
Copy link

codecov-io commented Nov 6, 2019

Codecov Report

Merging #8515 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8515   +/-   ##
=======================================
  Coverage   66.68%   66.68%           
=======================================
  Files         449      449           
  Lines       22684    22684           
  Branches     2366     2366           
=======================================
  Hits        15126    15126           
  Misses       7420     7420           
  Partials      138      138
Impacted Files Coverage Δ
...et/assets/src/visualizations/presets/MainPreset.js 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 571c474...13d4dd2. Read the comment docs.

Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graceguo-supercat
Copy link

we have to revert new table viz again because we found some feature regression. 😭

@graceguo-supercat graceguo-supercat merged commit d78e59b into apache:master Nov 6, 2019
graceguo-supercat pushed a commit that referenced this pull request Nov 13, 2019
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants