Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Table]Switch to new table(revision) #8560

Merged
merged 1 commit into from
Nov 13, 2019
Merged

[Table]Switch to new table(revision) #8560

merged 1 commit into from
Nov 13, 2019

Conversation

conglei
Copy link
Contributor

@conglei conglei commented Nov 13, 2019

CATEGORY

Choose one

  • Bug Fix
  • Enhancement (new features, refinement)
  • Refactor
  • Add tests
  • Build / Development Environment
  • Documentation

SUMMARY

As the revision of #8446

In this PR, the revision includes

  1. better calculation of the column width;
  2. lexicographically sorting strings;
  3. fixing word truncating issues;
  4. performance improvement

The related PRs are
apache-superset/superset-ui-plugins#253
apache-superset/superset-ui-plugins#246

TEST PLAN

Dev box

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

REVIEWERS

@kristw @etr2460 @graceguo-supercat

@codecov-io
Copy link

codecov-io commented Nov 13, 2019

Codecov Report

Merging #8560 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #8560   +/-   ##
======================================
  Coverage    66.8%   66.8%           
======================================
  Files         450     450           
  Lines       22734   22734           
  Branches     2366    2366           
======================================
  Hits        15187   15187           
  Misses       7409    7409           
  Partials      138     138
Impacted Files Coverage Δ
...et/assets/src/visualizations/presets/MainPreset.js 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a5c257...d5454ce. Read the comment docs.

@kristw kristw merged commit e14ca1a into apache:master Nov 13, 2019
@mistercrunch
Copy link
Member

The new tables look sweet, but there's an issue with width:
Screen Shot 2019-11-22 at 4 08 07 PM

Seems like we should force the table to be 100%, here it overflows :(

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.36.0 labels Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 0.36.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants