Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace deprecated command with environment file #27304

Merged
merged 1 commit into from
Feb 29, 2024
Merged

chore: Replace deprecated command with environment file #27304

merged 1 commit into from
Feb 29, 2024

Conversation

jongwooo
Copy link
Contributor

SUMMARY

Fixes #24063 (comment)
CC @geido

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dpgaspar
Copy link
Member

./scripts/ci_check_no_file_changes.sh is shell script so the unit test is being skipped here.

Run ./scripts/ci_check_no_file_changes.sh python
Searching for changes in python files

CHANGED FILES:
scripts/tag_latest_release.sh

No changes detected... Exiting with SUCCESS code

@dpgaspar
Copy link
Member

./scripts/ci_check_no_file_changes.sh is shell script so the unit test is being skipped here.

Run ./scripts/ci_check_no_file_changes.sh python
Searching for changes in python files

CHANGED FILES:
scripts/tag_latest_release.sh

No changes detected... Exiting with SUCCESS code

here this should help: #27303

@jongwooo
Copy link
Contributor Author

here this should help: #27303

@dpgaspar Great catch!

@dpgaspar
Copy link
Member

ok #27303 is merged, can you rebase, so we can catch the failing test please

@dpgaspar dpgaspar self-requested a review February 29, 2024 13:28
@jongwooo
Copy link
Contributor Author

ok #27303 is merged, can you rebase, so we can catch the failing test please

@dpgaspar Sure :)

@dpgaspar
Copy link
Member

ok you caught it!

Change: https://github.com/apache/superset/blob/master/tests/unit_tests/scripts/tag_latest_release_test.py#L47 to:
The tag does_not_exist does not exist. Please use a different tag.\n

@jongwooo
Copy link
Contributor Author

@dpgaspar Should I change line 36 as well?

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.57%. Comparing base (7854b62) to head (c7f1738).
Report is 1475 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #27304      +/-   ##
==========================================
+ Coverage   67.33%   69.57%   +2.24%     
==========================================
  Files        1908     1908              
  Lines       74544    74544              
  Branches     8314     8314              
==========================================
+ Hits        50196    51866    +1670     
+ Misses      22296    20626    -1670     
  Partials     2052     2052              
Flag Coverage Δ
mysql 78.00% <ø> (ø)
postgres 78.10% <ø> (ø)
python 82.88% <ø> (+4.64%) ⬆️
sqlite 77.62% <ø> (ø)
unit 56.50% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dpgaspar
Copy link
Member

@dpgaspar Should I change line 36 as well?

probably, test it

Copy link
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! thank you for doing this

@dpgaspar dpgaspar merged commit 234a139 into apache:master Feb 29, 2024
27 checks passed
@jongwooo jongwooo deleted the chore/replace-deprecated-command-with-environment-file branch February 29, 2024 15:19
elif [[ "$compare_result" == "greater" ]]; then
echo "This release tag ${GITHUB_TAG_NAME} is newer than the latest."
echo "::set-output name=SKIP_TAG::false"
echo "SKIP_TAG=false" >> $GITHUB_OUTPUT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jongwooo Thanks for this fix! I think we may need to update this line here as well from SKIP_TAG::false to SKIP_TAG=false. Do you mind adding one more PR with this other change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eschutho That'd be great.

return "SKIP_TAG::false" in output
right?

sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants