-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Replace deprecated command with environment file #27304
chore: Replace deprecated command with environment file #27304
Conversation
./scripts/ci_check_no_file_changes.sh is shell script so the unit test is being skipped here.
|
here this should help: #27303 |
ok #27303 is merged, can you rebase, so we can catch the failing test please |
ok you caught it! Change: https://github.com/apache/superset/blob/master/tests/unit_tests/scripts/tag_latest_release_test.py#L47 to: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #27304 +/- ##
==========================================
+ Coverage 67.33% 69.57% +2.24%
==========================================
Files 1908 1908
Lines 74544 74544
Branches 8314 8314
==========================================
+ Hits 50196 51866 +1670
+ Misses 22296 20626 -1670
Partials 2052 2052
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! thank you for doing this
elif [[ "$compare_result" == "greater" ]]; then | ||
echo "This release tag ${GITHUB_TAG_NAME} is newer than the latest." | ||
echo "::set-output name=SKIP_TAG::false" | ||
echo "SKIP_TAG=false" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eschutho That'd be great.
superset/scripts/build_docker.py
Line 82 in ad6327d
return "SKIP_TAG::false" in output |
SUMMARY
Fixes #24063 (comment)
CC @geido
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION