Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): check file changes for python should include the scripts folders #27303

Merged
merged 4 commits into from
Feb 29, 2024

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Feb 29, 2024

SUMMARY

Unittest is not being triggered when a change on scripts folder is made, yet we have unittests for these scripts.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dpgaspar dpgaspar changed the title fix: tags unittests fix(ci): check file changes for python should include the scripts folders Feb 29, 2024
@dpgaspar dpgaspar requested a review from geido February 29, 2024 11:51
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.57%. Comparing base (d6e8dd1) to head (1cc7472).
Report is 1478 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #27303      +/-   ##
==========================================
+ Coverage   67.33%   69.57%   +2.24%     
==========================================
  Files        1908     1908              
  Lines       74543    74543              
  Branches     8313     8313              
==========================================
+ Hits        50197    51867    +1670     
+ Misses      22294    20624    -1670     
  Partials     2052     2052              
Flag Coverage Δ
mysql 77.97% <ø> (ø)
postgres 78.10% <ø> (ø)
python 82.88% <ø> (+4.64%) ⬆️
sqlite 77.62% <ø> (ø)
unit 56.50% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dpgaspar dpgaspar merged commit b16c899 into apache:master Feb 29, 2024
29 checks passed
@dpgaspar dpgaspar deleted the fix/tgs-unit-tests branch February 29, 2024 13:10
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants