Skip to content

Commit

Permalink
chore: Replace deprecated command with environment file (#27304)
Browse files Browse the repository at this point in the history
  • Loading branch information
jongwooo authored Feb 29, 2024
1 parent fa04eec commit 234a139
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
12 changes: 6 additions & 6 deletions scripts/tag_latest_release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -98,21 +98,21 @@ done

if [ -z "${GITHUB_TAG_NAME}" ]; then
echo "Missing tag parameter, usage: ./scripts/tag_latest_release.sh <GITHUB_TAG_NAME>"
echo "::set-output name=SKIP_TAG::true"
echo "SKIP_TAG=true" >> $GITHUB_OUTPUT
exit 1
fi

if [ -z "$(git_show_ref)" ]; then
echo "The tag ${GITHUB_TAG_NAME} does not exist. Please use a different tag."
echo "::set-output name=SKIP_TAG::true"
echo "SKIP_TAG=true" >> $GITHUB_OUTPUT
exit 0
fi

# check that this tag only contains a proper semantic version
if ! [[ ${GITHUB_TAG_NAME} =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]
then
echo "This tag ${GITHUB_TAG_NAME} is not a valid release version. Not tagging."
echo "::set-output name=SKIP_TAG::true"
echo "SKIP_TAG=true" >> $GITHUB_OUTPUT
exit 1
fi

Expand Down Expand Up @@ -177,14 +177,14 @@ done
# Determine the result based on the comparison
if [[ -z "$compare_result" ]]; then
echo "Versions are equal"
echo "::set-output name=SKIP_TAG::true"
echo "SKIP_TAG=true" >> $GITHUB_OUTPUT
elif [[ "$compare_result" == "greater" ]]; then
echo "This release tag ${GITHUB_TAG_NAME} is newer than the latest."
echo "::set-output name=SKIP_TAG::false"
echo "SKIP_TAG=false" >> $GITHUB_OUTPUT
# Add other actions you want to perform for a newer version
elif [[ "$compare_result" == "lesser" ]]; then
echo "This release tag ${GITHUB_TAG_NAME} is older than the latest."
echo "This release tag ${GITHUB_TAG_NAME} is not the latest. Not tagging."
# if you've gotten this far, then we don't want to run any tags in the next step
echo "::set-output name=SKIP_TAG::true"
echo "SKIP_TAG=true" >> $GITHUB_OUTPUT
fi
4 changes: 2 additions & 2 deletions tests/unit_tests/scripts/tag_latest_release_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def wrapped(*args, **kwargs):
"tag, expected_output",
[
("1.0.0", "This release tag 1.0.0 is older than the latest."),
("2.1.0", "Versions are equal\n::set-output name=SKIP_TAG::true"),
("2.1.0", "Versions are equal\n"),
("2.1.1", "This release tag 2.1.1 is newer than the latest."),
("3.0.0", "This release tag 3.0.0 is newer than the latest."),
("2.1.0rc1", "This tag 2.1.0rc1 is not a valid release version. Not tagging."),
Expand All @@ -44,7 +44,7 @@ def wrapped(*args, **kwargs):
("2.1", "This tag 2.1 is not a valid release version. Not tagging."),
(
"does_not_exist",
"The tag does_not_exist does not exist. Please use a different tag.\n::set-output name=SKIP_TAG::true",
"The tag does_not_exist does not exist. Please use a different tag.\n",
),
],
)
Expand Down

0 comments on commit 234a139

Please sign in to comment.