[improve][admin] PulsarAdminBuilderImpl overrides timeout properties passed through config map #17375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technoboy-
added
type/enhancement
coderzc
approved these changes
Aug 31, 2022
alpreu
reviewed
Sep 14, 2022
...-admin/src/test/java/org/apache/pulsar/client/admin/internal/PulsarAdminBuilderImplTest.java
Outdated
Show resolved
Hide resolved
|
The pr had no activity for 30 days, mark with Stale label. |
Codecov Report
@@ Coverage Diff @@
## master #17375 +/- ##
=============================================
+ Coverage 34.91% 46.89% +11.97%
- Complexity 5707 17869 +12162
=============================================
Files 607 1574 +967
Lines 53396 128303 +74907
Branches 5712 14115 +8403
=============================================
+ Hits 18644 60162 +41518
- Misses 32119 61955 +29836
- Partials 2633 6186 +3553
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
The pr had no activity for 30 days, mark with Stale label. |
mattisonchao
approved these changes
Nov 18, 2022
codelipenghui
approved these changes
Nov 18, 2022
|
@Technoboy- Is there any specific reason that this bug fix isn't cherry-picked to maintenance branches? |
Technoboy-
added a commit
that referenced
this pull request
Feb 8, 2023
…passed through config map (#17375)
Ah, it's not a bug fix. I have cherry-picked to branch-2.11, because there are some modification based on this patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17333
Master Issue: #17333
Motivation
Support PulsarAdminBuilderImpl overrides timeout properties passed through config map.
Documentation
doc-not-needed(Please explain why)