Fix admin props failing on duration types #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onobc
commented
Nov 26, 2022
...t-autoconfigure/src/main/java/org/springframework/pulsar/autoconfigure/PulsarProperties.java
Show resolved
Hide resolved
onobc
commented
Nov 26, 2022
...t-autoconfigure/src/main/java/org/springframework/pulsar/autoconfigure/PulsarProperties.java
Show resolved
Hide resolved
onobc
commented
Nov 26, 2022
...oconfigure/src/test/java/org/springframework/pulsar/autoconfigure/PulsarPropertiesTests.java
Show resolved
Hide resolved
onobc
commented
Nov 26, 2022
| if (conf.remove("connectTimeout") instanceof Duration connectTimeout) { | ||
| builder.connectionTimeout((int) connectTimeout.toMillis(), TimeUnit.MILLISECONDS); | ||
|
|
||
| // Workaround the fact that the PulsarAdminImpl does not attempt to construct the |
There was a problem hiding this comment.
I would like to move this to PulsarAdminBuilderImpl.loadConf like we did for the auth stuff below.
|
I am going to merge this in order to get a 🟢 on the CI as I have a follow on PR to bump to SB3.0.0. Any PR suggestions I will gladly handle post-merge (cc: @cbornet ) |
cbornet
reviewed
Nov 27, 2022
| map.from(this::getConnectionTimeout).asInt(Duration::toMillis).to(properties.in("connectionTimeoutMs")); | ||
| map.from(this::getReadTimeout).asInt(Duration::toMillis).to(properties.in("readTimeoutMs")); | ||
| map.from(this::getRequestTimeout).asInt(Duration::toMillis).to(properties.in("requestTimeoutMs")); | ||
| map.from(this::getAutoCertRefreshTime).asInt(Duration::toMillis).to(properties.in("autoCertRefreshTimeMs")); |
There was a problem hiding this comment.
For autoCertRefreshTime we should convert to seconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PATL @cbornet @sobychacko
Fixes #239