Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] PulsarAdminBuilderImpl overrides timeout properties passed through config map #17333

Closed
1 of 2 tasks
alpreu opened this issue Aug 29, 2022 · 1 comment · Fixed by #17375
Closed
1 of 2 tasks

[Bug] PulsarAdminBuilderImpl overrides timeout properties passed through config map #17333

alpreu opened this issue Aug 29, 2022 · 1 comment · Fixed by #17375
Assignees
Labels
Stale type/bug The PR fixed a bug or issue reported a bug

Comments

@alpreu
Copy link
Contributor

alpreu commented Aug 29, 2022

Search before asking

  • I searched in the issues and found nothing similar.

Version

master commit id 0e149ef

Minimal reproduce step

PulsarAdminBuilder allows configuration of PulsarAdmin either by using the setters on the builder, or by using the loadConf method that takes in a map of configuration properties.

The properties:

  • readTimeout
  • connectionTimeout
  • requestTimeout

can currently only be correctly applied when using the builder setters (e.g. setReadTimeout) because the build() method accesses these as private fields in PulsarAdminBuilderImpl. If these properties are set through the config map, loadConf does not update these private fields. This results in the config values being ignored and overridden by the default values in PulsarAdminBuilderImpl

What did you expect to see?

Properties should be applied correctly using config map or builder methods,

What did you see instead?

Timeout properties passed in via config map get overwritten by the builders default values.

Anything else?

No response

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@github-actions
Copy link

The issue had no activity for 30 days, mark with Stale label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
2 participants