Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] broker selection not using table name #9902

Merged
merged 2 commits into from
Dec 3, 2022

Conversation

walterddr
Copy link
Contributor

this fixes: #9695.

@walterddr walterddr marked this pull request as ready for review December 2, 2022 15:41
@walterddr walterddr force-pushed the hotfix_connection_broker_select branch from 2879266 to 03bd3db Compare December 2, 2022 15:46
Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor comments

Co-authored-by: Xiaotian (Jackie) Jiang <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2022

Codecov Report

Merging #9902 (e5c6b92) into master (041865a) will decrease coverage by 4.33%.
The diff coverage is 58.33%.

@@             Coverage Diff              @@
##             master    #9902      +/-   ##
============================================
- Coverage     68.65%   64.31%   -4.34%     
+ Complexity     5049     5036      -13     
============================================
  Files          1973     1928      -45     
  Lines        106008   103874    -2134     
  Branches      16060    15823     -237     
============================================
- Hits          72775    66808    -5967     
- Misses        28110    32243    +4133     
+ Partials       5123     4823     -300     
Flag Coverage Δ
integration1 ?
unittests1 67.93% <ø> (-0.03%) ⬇️
unittests2 15.81% <58.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../main/java/org/apache/pinot/client/Connection.java 59.61% <58.33%> (+17.39%) ⬆️
...va/org/apache/pinot/common/config/NettyConfig.java 0.00% <0.00%> (-100.00%) ⬇️
...a/org/apache/pinot/common/metrics/MinionMeter.java 0.00% <0.00%> (-100.00%) ⬇️
...g/apache/pinot/common/metrics/ControllerMeter.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/pinot/common/metrics/BrokerQueryPhase.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/pinot/common/metrics/MinionQueryPhase.java 0.00% <0.00%> (-100.00%) ⬇️
...ache/pinot/server/access/AccessControlFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...he/pinot/common/messages/TableDeletionMessage.java 0.00% <0.00%> (-100.00%) ⬇️
...pinot/minion/exception/TaskCancelledException.java 0.00% <0.00%> (-100.00%) ⬇️
...not/common/exception/HttpErrorStatusException.java 0.00% <0.00%> (-100.00%) ⬇️
... and 401 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@walterddr walterddr merged commit 4ae6d35 into apache:master Dec 3, 2022
@walterddr walterddr deleted the hotfix_connection_broker_select branch December 6, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] ConnectorFactory cannot get livebroker mapping
3 participants