-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hotfix] broker selection not using table name #9902
[hotfix] broker selection not using table name #9902
Conversation
2879266
to
03bd3db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor comments
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/Connection.java
Outdated
Show resolved
Hide resolved
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/Connection.java
Show resolved
Hide resolved
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/Connection.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Xiaotian (Jackie) Jiang <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #9902 +/- ##
============================================
- Coverage 68.65% 64.31% -4.34%
+ Complexity 5049 5036 -13
============================================
Files 1973 1928 -45
Lines 106008 103874 -2134
Branches 16060 15823 -237
============================================
- Hits 72775 66808 -5967
- Misses 28110 32243 +4133
+ Partials 5123 4823 -300
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
this fixes: #9695.